Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toggle Switch Tweaks #692

Merged
merged 2 commits into from
Mar 12, 2019
Merged

Toggle Switch Tweaks #692

merged 2 commits into from
Mar 12, 2019

Conversation

lidel
Copy link
Member

@lidel lidel commented Mar 6, 2019 •
edited
Loading

This PR is implementing some feedback from #689:

on/on/off off/disabled/on
2019-03-06--14-57-50 2019-03-06--15-03-21

  • Replaced checkboxes on Preferences screen:

    2019-03-06--14-56-36

  • fixed CSS for checked/disabled

@lidel
style: change toggle colors
495b8bf 
Makes on state less agressive and improves contrast of disabled state.
@lidel
feat: toggle switch in Preferences
5a3cb17 
- fixed CSS for checked/disabled
- updated colors based on feedback in #689
- enabled on Preferences screen
@ghost ghost assigned lidel Mar 6, 2019
@ghost ghost added the status/in-progress In progress label Mar 6, 2019
@lidel lidel mentioned this pull request Mar 6, 2019
Closed
@lidel lidel requested a review from a team March 6, 2019 14:18
hacdias
hacdias approved these changes Mar 12, 2019
View reviewed changes
Copy link
Member

@hacdias hacdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@lidel lidel mentioned this pull request Mar 12, 2019
Merged
@lidel lidel merged commit ff71012 into master Mar 12, 2019
@ghost ghost removed the status/in-progress In progress label Mar 12, 2019
@lidel lidel deleted the style/browser-action branch March 12, 2019 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hacdias hacdias hacdias approved these changes

@fsdiogo fsdiogo fsdiogo approved these changes

Assignees

@lidel lidel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lidel @hacdias @fsdiogo