fix: disable window.ipfs #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firefox supports dynamic injection, plus we recently added dedicated manifest.chromium.json so it makes sense to remove it from Firefox build.
lidel
force-pushed
the
refactor/limit-window.ipfs-injection
branch
from
db1186e
to
d6511cb
Compare
This force-disables injection of window.ipfs and fades out the experiments on Preferences screen. We will restore it after move to JS API with Async Await and Async Iterables is finished. Context: #852 (comment) #843
lidel
changed the title
lidel
changed the title
This was referenced Oct 19, 2020
Closed
6 tasks
SgtPooki
added a commit
to ipfs/ipfs-webui
that referenced
this pull request
Jul 1, 2023
SgtPooki
added a commit
to ipfs/ipfs-webui
that referenced
this pull request
Jul 1, 2023
window.ipfs is no longer available, so we no longer need this code see ipfs/ipfs-companion#777
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tldr
This PR disables
window.ipfsexperiment.Rationale
window.ipfsto behave the old way.window.ipfsand use fallback instead.This will let people to migrate away at their own convenience.
Changes
window.ipfs, at least until Migration to JS API with Async Await and Async Iterables (Migration to JS API with Async Await and Async Iterables #843)manifest.chromium.jsonso it makes sense to remove it from Firefox build.