feat: make Preferences link to docs site #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessicaschilling
changed the title
|
@lidel, for your reviewing pleasure! |
lidel
reviewed
Apr 28, 2020
There was a problem hiding this comment.
Thank you @jessicaschilling!
I will circle back to this docs migration before next release of ipfs-companion.
Note to self:
- revisit which docs are dev-only and should be moved back
- update link to privacy policy at Chrome Web Store when this is merged.
@jessicaschilling does this sound ok? |
|
@lidel -- good idea on capitalization, thanks. |
We need this so users of older versions of ipfs-companion won't see "not found" error.
this needs to happen when we restore injection of window.ipfs
lidel
approved these changes
May 10, 2020
There was a problem hiding this comment.
@jessicaschilling thank you so much for tackling this!
(I am sorry I was slow to review, that produced some unnecessary back and forth)
I made small changes:
- removed .gif images (loading them from IPFS instead: c3256a4)
- restored
.mdused by older versions of IPFS Companion (ab90b04): I've put a link to article at docs portal in each, so user will get to the right place eventually (we can removedocs/next quarter) - swapped link to the closed issue you mentioned with link to subdomain docs, as those provide information why Origin isolation provided by subdomain gateway is important (5cc608e)
I'm merging this to rebase and unblock #879
lidel
changed the title
4 tasks
|
Thanks for all those details! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
privacy-policy.mdandexamplesdirectory to top level; fixes links to privacy policy that result from the movedocsdirectory; all the remaining content has been moved to docs beta per Migrate Companion docs ipfs-docs#182Closes #595 BUT shouldn't be merged until ipfs/ipfs-docs#182 is merged and docs are in place on the docs site.
One additional note: The "Load websites from custom gateway" option still points to #667 for its "Learn more" link. @lidel, are you up for writing a brief explainer to put in the docs once that issue is closed (presumably 0.5 release)?