fix: show Files after import on windows (#1853)

this aims to fix issue from #1815
ipfs · Jul 5, 2021 · 22d189c · 22d189c
1 parent 2a0268d
commit 22d189c
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 7 deletions.
diff --git a/src/add-to-ipfs.js b/src/add-to-ipfs.js
@@ -69,6 +69,8 @@ function sendNotification (failures, successes, launchWebUI, path) {
   }
 
   fn({ title, body }, () => {
+    // force refresh for Files screen to pick up newly added items
+    // https://github.com/ipfs/ipfs-desktop/issues/1763
     launchWebUI(link, { forceRefresh: true })
   })
 }

diff --git a/src/webui/index.js b/src/webui/index.js
@@ -107,15 +107,16 @@ module.exports = async function (ctx) {
       logger.info('[web ui] launching web ui')
     } else {
       logger.info(`[web ui] navigate to ${path}`)
-      window.webContents.send('updatedPage', path)
       url.hash = path
+      window.webContents.loadURL(url.toString())
     }
-
     if (focus) {
       window.show()
       window.focus()
       dock.show()
     }
+    // load again: minimize visual jitter on windows
+    if (path) window.webContents.loadURL(url.toString())
   }
 
   function updateLanguage () {

diff --git a/src/webui/preload.js b/src/webui/preload.js
@@ -10,9 +10,11 @@ const urlParams = new URLSearchParams(window.location.search)
 
 function checkIfVisible () {
   if (document.hidden) {
+    if (window.location.hash === '#/blank') return // skip, already blank
     previousHash = window.location.hash
     window.location.hash = '/blank'
   } else {
+    if (previousHash === '#/blank') return // skip
     window.location.hash = previousHash
   }
 }
@@ -28,11 +30,6 @@ window.localStorage.setItem = function () {
 
 let previousHash = null
 
-ipcRenderer.on('updatedPage', (_, url) => {
-  previousHash = url
-  window.location.hash = url
-})
-
 document.addEventListener('visibilitychange', () => {
   checkIfVisible()
 })
@@ -41,6 +38,12 @@ document.addEventListener('DOMContentReady', () => {
   checkIfVisible()
 })
 
+// track hash changes, so checkIfVisible always has the right previousHash
+document.addEventListener('hashchange', () => {
+  if (window.location.hash === '#/blank') return // skip
+  previousHash = window.location.hash
+})
+
 window.ipfsDesktop = {
   countlyAppKey: COUNTLY_KEY,