Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Launch on startup" is grayed out in v0.10.2 #1290

Closed
alexhenrie opened this issue Dec 18, 2019 · 7 comments · Fixed by #1334
Closed

"Launch on startup" is grayed out in v0.10.2 #1290

alexhenrie opened this issue Dec 18, 2019 · 7 comments · Fixed by #1334
Labels
area/linux Linux area/macos MacOS area/windows Windows P1 High: Likely tackled by core team if no one steps up

Comments

@alexhenrie
Copy link
Contributor

In the IPFS Desktop settings page, the "Launch on startup" checkbox is grayed out and can no longer be checked. A regression test said:

5dc624e3eba71d8097606aeded5af3bdaee3252c is the first bad commit
commit 5dc624e3eba71d8097606aeded5af3bdaee3252c
Author: Henrique Dias <hacdias@gmail.com>
Date:   Wed Oct 30 17:52:29 2019 +0000

    feat: web ui 2.6.0 (#1226)
    
    See https://github.com/ipfs-shipyard/ipfs-webui/releases/tag/v2.6.0.

 package.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
@hacdias
Copy link
Member

hacdias commented Dec 20, 2019

Which OS are you running?

@alexhenrie
Copy link
Contributor Author

Arch Linux, fully updated, IPFS Desktop built from source.

@hacdias
Copy link
Member

hacdias commented Dec 22, 2019

That is so weird... it says 5dc624e3eba71d8097606aeded5af3bdaee3252c is the first bad commit, but even looking at it, we are just updating Web UI:

5dc624e

Does the previous commit work?

@sixcorners
Copy link

sixcorners commented Jan 27, 2020

It's grayed out for the person in this ticket: #1321
It's grayed out for me too.
The built in chrome dev tools says my os.platform() is "browser". I am viewing it through the ipfs-desktop UI.

@sixcorners
Copy link

sixcorners commented Jan 27, 2020

Also it looks like this stuff doesn't actually make anything happen on startup..
It writes a file to ~/.config/autostart/ or something on linux and mac and windows get this business: app.setLoginItemSettings({ openAtLogin: true }).
Startup and login are very different things...

Could the option be changed to "Launch on login" or something?

@hacdias hacdias changed the title "Launch on startup" is grayed out in v0.10.2 on Linux "Launch on startup" is grayed out in v0.10.2 Jan 27, 2020
@hacdias hacdias added area/linux Linux area/macos MacOS P1 High: Likely tackled by core team if no one steps up area/windows Windows labels Jan 27, 2020
@hacdias
Copy link
Member

hacdias commented Jan 27, 2020

@sixcorners setLoginItemSettings is only supported on Windows and macOS per the docs.

Could the option be changed to "Launch on login" or something?

Personally, I don't mind.

The built in chrome dev tools says my os.platform() is "browser"

Yes, and this seems to be where the bug is. Apparently, os.platform() returns browser only on production. During development, inside the Electron browser, it works as expected.

@sixcorners
Copy link

@hacdias That's a bummer. How can it be fixed? Could the node side of the app be asked for that information or is there a better way to do it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/linux Linux area/macos MacOS area/windows Windows P1 High: Likely tackled by core team if no one steps up
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants