Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cannot open 0.17.0 from zip release on mac #1922

Closed
sneak opened this issue Oct 26, 2021 · 8 comments · Fixed by #1932
Closed

cannot open 0.17.0 from zip release on mac #1922

sneak opened this issue Oct 26, 2021 · 8 comments · Fixed by #1932
Assignees
@lidel
Labels
need/analysis Needs further analysis before proceeding

Comments

@sneak
Copy link

sneak commented Oct 26, 2021

  • OS: macOS
  • Version of IPFS Desktop 0.17.0
nostromo:~/Downloads$ shasum IPFS-Desktop-0.17.0-mac.zip
bfb2285198c4172dbe7d54394165163fc9017432  IPFS-Desktop-0.17.0-mac.zip

Describe the bug

Unzipping the file IPFS-Desktop-0.17.0-mac.zip results in an application bundle that cannot be opened.

Screen Shot 2021-10-26 at 03 26 04

file suggests that it's the right arch for this machine:

nostromo:~/Downloads/IPFS Desktop.app/Contents/MacOS$ file IPFS\ Desktop
IPFS Desktop: Mach-O 64-bit executable x86_64
@sneak sneak added the need/triage Needs initial labeling and prioritization label Oct 26, 2021
@sneak sneak changed the title cannot open 0.17.0 on mac cannot open 0.17.0 from zip release on mac Oct 26, 2021
@sneak
Copy link
Author

sneak commented Oct 26, 2021

The DMG release file of 0.17.0 is fine:

nostromo:~/Downloads$ shasum IPFS-Desktop-0.17.0.dmg
e2749b399350e53d35ab39e687e96dc6fee9be0a  IPFS-Desktop-0.17.0.dmg

@lidel
Copy link
Member

lidel commented Nov 19, 2021 •
edited
Loading

@sneak I don't believe .zip should be used for installation, it may be artifact used for fetching deltas for partial upgrades (or something from older macOS?).

@galargh mind taking a look in spare time?

@lidel lidel added the need/analysis Needs further analysis before proceeding label Nov 19, 2021
@chrleon
Copy link

chrleon commented Nov 19, 2021

Downloading the DMG works.

@galargh
Copy link
Contributor

galargh commented Nov 19, 2021 •
edited
Loading

I do agree dmg is the way to go but, since I had a second I have tried repeating the described steps. Here are some things I've noticed on m1 mac running Monterrey:

  • couldn't unzip it with unzip; had to fallback to jar xvf
  • failed to launch after unpack
  • briefly opened (the icon showed up) after making it executable but crashed with failing to load '.../IPFS Desktop.app/Contents/MacOS/../Frameworks/Electron Framework.framework/Electron Framework' (not a mach-o file) (I don't think electron is significant here - it's just first lexicographically)

@ipfs ipfs deleted a comment from rigan0707 Nov 26, 2021
@lidel
Copy link
Member

lidel commented Nov 26, 2021 •
edited
Loading

Ok, it seems zip is built only to provide interop with something called Squirrel.Mac (https://github.com/Squirrel/Squirrel.Mac).
It does not seem to be useful these days –or is it?

I am going to remove it so mac users are not confused by "broken zip" – please comment in #1932 if you see any problems with that approach 🙏

lidel added a commit that referenced this issue Nov 26, 2021
@lidel
fix: remove zip for Squirrel.Mac
ee1d8b5 
See rationale:
#1922 (comment)

Closes #1922
@lidel lidel mentioned this issue Nov 26, 2021
Merged
@lidel lidel removed the need/triage Needs initial labeling and prioritization label Dec 3, 2021
lidel added a commit that referenced this issue Dec 3, 2021
@lidel
fix: remove zip for Squirrel.Mac (#1932)
ae3f40e 
See rationale:
#1922 (comment)

Closes #1922
@lidel
Copy link
Member

lidel commented Dec 10, 2021 •
edited
Loading

Reopening, as the removal of this "useless" .zip may break autoupdate on macOS 🤦‍♂️:

This is pretty hard to test, because of Apple's walled garden (notarization and signing security dance). I think the fastest way is to move forward with release, see if there are any issues on macOS, and ship a quick patch release if necessary.

So, the next steps here are:

  • rest during the weekend 🙃
  • release 0.18.0 on Monday
  • test autoupdate on macOS by installing 0.17.0 and waiting for it to autoupdate to 0.18.0
    • if it fails, set staged rollout of 0.18.0 so only 1% of mac users gets an update, quickly tag 0.18.1 with restored .zip for macOS and confirm update 0.17.0→0.18.1
  • close this issue

@lidel lidel reopened this Dec 10, 2021
@lidel lidel self-assigned this Dec 10, 2021
lidel added a commit that referenced this issue Dec 13, 2021
@lidel
fix: restore zip for macOS autoupdates
fb8645d 
This reverts #1932
because of reasons desribed in
#1922 (comment)
@lidel
Copy link
Member

lidel commented Dec 13, 2021 •
edited
Loading

@lidel
Copy link
Member

lidel commented Dec 13, 2021 •
edited
Loading

Shipped fix in 0.18.1 and opened electron-userland/electron-builder#6496 to add electron-builder docs about the bug they were aware of since.. 2017 :|

We have docs at https://docs.ipfs.io/install/ipfs-desktop/#macos that ask people to use .dmg, can't do anything better than this, I am afraid.

@lidel lidel closed this as completed Dec 13, 2021
@galargh galargh moved this from New to Done in IP Productivity 🆙 Jan 4, 2022
@galargh galargh moved this from 🤔 Triage to 🥳 Done in InterPlanetary Developer Experience Apr 14, 2022
@tinytb tinytb mentioned this issue Oct 6, 2022
Closed
@lidel lidel mentioned this issue Oct 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidel lidel

Labels
need/analysis Needs further analysis before proceeding
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove zip for Squirrel.Mac ipfs/ipfs-desktop
4 participants
@lidel @chrleon @sneak @galargh