Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Station crashes when "open directory" dialog is canceled #521

Closed
machawk1 opened this issue Dec 4, 2017 · 3 comments
Closed

Station crashes when "open directory" dialog is canceled #521

machawk1 opened this issue Dec 4, 2017 · 3 comments

Comments

@machawk1
Copy link
Contributor

machawk1 commented Dec 4, 2017

macOS 10.13.1
Commit b7e2db6 of redesign branch.

Selecting the "folder" icon from the menu UI then hitting the cancel button causes Station to crash with the error

error: Uncaught Exception: Cannot read property 'length' of undefined {}
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! ipfs-station@0.1.0 start: `electron-forge start`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the ipfs-station@0.1.0 start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

station
@hacdias
Copy link
Member

hacdias commented Dec 4, 2017

Thank you!! I'll take care ASAP!

@hacdias
Copy link
Member

hacdias commented Dec 4, 2017

Fixed!

@hacdias hacdias closed this as completed Dec 4, 2017
hacdias added a commit that referenced this issue Dec 4, 2017
@hacdias
fix #521
d2eb903
@machawk1
Copy link
Contributor Author

machawk1 commented Dec 4, 2017

Pulled and verified. Thanks for the quick turnaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@machawk1 @hacdias