Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualise the status of the ipfs daemon and be robust to it not stopping. #857

Closed
olizilla opened this issue Mar 5, 2019 · 4 comments
Closed
Assignees

Comments

@olizilla
Copy link
Member

olizilla commented Mar 5, 2019

If you leave the IPFS daemon running for a long time, trying to stop it can take a long time. The user has no clue what is going on, so it just seems like the app is stalled... I took a screen recording of a particularly suprising session, that stalled, then crashed, then installed an update

https://ipfs.io/ipfs/QmWEDikLypHaWYNJC3ftmGNkuZCogeSoMSnwAp7UaLyCdz/ipfs-desktop-no-node-status.mp4

The app should not crash if the daemon takes a long time to stop. We may have to consider killing the process or offering the user a way to do it, if it does take a really long time. Command line users are just another ctrl+c away from killing it.

We could indicate the current status of the daemon by adding a label to the "Status" entry on the menubar with labels for ["stopped", "starting...", "connected", "stopping..."] or similar. I've used "connected" for the all ok label, as that mirrors the language in the web ui.

We would be good if the power button visually indicated if the "power" was on or not, as companion does. It may make more sense as a slider toggle switch, as per ipfs/ipfs-companion#689 (comment)

@hacdias
Copy link
Member

hacdias commented Mar 12, 2019

image

I personally like the idea of keeping the power button and add a circle on its right telling the current state,

@hacdias
Copy link
Member

hacdias commented Mar 12, 2019

image

image

image

@olizilla
Copy link
Member Author

For the status, I'd go for a label + colored circle. We can add it to the status section in the menu. We can't rely on just a color change to communicate state to the user as many folks have some form of color blindness.

This is what docker does
Screenshot 2019-03-12 at 12 08 57

A toggle would work for the start/stop button, tho the power button does match the one in companion right now. The smallest change is that it should give the user some feedback that it was clicked. The one in companion turns gray when the intergration is switched off.

@fsdiogo
Copy link
Contributor

fsdiogo commented Mar 12, 2019

@hacdias I'm also up for keeping the power button instead of a toggle.

This can be tricky as it may confuse users and seem like a button too:

stat

This was referenced Mar 12, 2019
@ghost ghost added the in progress label Mar 12, 2019
@ghost ghost removed the in progress label Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants