Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to menubar menu only #865

Closed
hacdias opened this issue Mar 12, 2019 · 14 comments
Closed

Move to menubar menu only #865

hacdias opened this issue Mar 12, 2019 · 14 comments
Assignees

Comments

@hacdias
Copy link
Member

hacdias commented Mar 12, 2019

Most menubar apps have the same behaviour when using the right or left click and right now we have different actions for both. On left click, we open the real React menubar and with the right click we option a native menu with some options.

Since this goes against what most do, probably people would get confused and we thought about moving it only to a menubar menu app. With this we could simplify the user experience (on all OSes) and reduce lots of dependencies we need right now.

/cc @ipfs-shipyard/gui

@fsdiogo
Copy link
Contributor

fsdiogo commented Mar 12, 2019

On macOS it's not rare a menubar app having different actions for click, although I can agree that most users may be unaware of that capability.

Would the right click actions be aggregated somehow in the menubar?

@lidel
Copy link
Member

lidel commented Mar 12, 2019

As a minimalist, I'm for making it a simple menu that looks native to the OS.
Would love to hear what others think about this approach.

@hacdias @fsdiogo are you able to add screenshots of the native menu under Windows/Mac?
I believe seeing it will make it easier for others to join this discussion.

@hacdias
Copy link
Member Author

hacdias commented Mar 12, 2019

@fsdiogo no, it would be the opposite way: just have the native menubar. It would be just simpler for everyone.

@lidel here's one on macOS: #857 (comment):

Screenshot 2019-03-12 at 12 08 57

@olizilla
Copy link
Member

Docker for mac is a useful reference point for this (as a fellow OS intergration for a command line tool with a long-running process behind it)

Screenshot 2019-03-12 at 14 40 22

@hacdias
Copy link
Member Author

hacdias commented Mar 12, 2019

Docker on Windows:

@olizilla
Copy link
Member

In conversation with @ericronne it came up that the menubar UI was mostly still there becuase this app started life as a menubar app, and then we changed course.

I am in favour of using a system menubar (like the docker example above) for simplicity, and to make it feel more like a native app, and to remove the left/right click distinction, where left clicks gets you a fancy menu, and right click gets you a system menu with different options

Current right click menu in IPFS Desktop

Screenshot 2019-03-12 at 14 44 41

@hacdias
Copy link
Member Author

hacdias commented Mar 12, 2019

A possible idea of what it could be (options would need to be tweaked):

image

We could mimic the status in the top as Docker Desktop do. We could perhaps hide the versions on a sub menu or About dialog.

And perhaps hiding "Configuration folder", "logs directory" and eventually "IPFS repository" under advanced sub menu.

@fsdiogo
Copy link
Contributor

fsdiogo commented Mar 12, 2019

@fsdiogo no, it would be the opposite way: just have the native menubar. It would be just simpler for everyone.

Oh ok, wasn't expecting that to be honest 😮

Well, it kind of makes sense as right now we don't get that much with the menu bar app, being Web UI the central point of it, so I think it's ok just having a native menu. I'm up for it 👍

@hacdias
Copy link
Member Author

hacdias commented Mar 12, 2019

@fsdiogo yeah, it might be a little sad (and I trully feel it since I've been working on this for a long time haha), but it just gets a better native feeling and simplifies everything

@ericronne
Copy link

I'd add my vote in favor of "killing our darlings" in this case, and removing the custom menu …
image
… in favor a native-os one.

The current behavior seems a little unorthodox, since the five primary menu options (Status, Files, Explore, &c) merely open the desktop app, with the chosen section active. I don't think it users would mind if we merely offered an "Open IPFS Desktop" option instead.

I'm unclear about some of the other functionality at this point, but it might be good to avoid duplicating options which are available in the desktop app, unless they are things a user would want to fiddle with frequently.

@hacdias
Copy link
Member Author

hacdias commented Mar 12, 2019

image

This is what I've been working for the last hour. Just to try it out. It would work. We'd still use Electron. It looks more native on macOS than on Windows because Chromium never used Windows' native context menu. But I don't believe that'd be an issue. Yes, the color icon is not aligned/with the correct size.

I wonder if in the future we could ditch Electron and find a way to create a menubar without the heavy baggage that Electron is.

What do you think about this?

@ericronne
Copy link

I'd suggest collapsing "Status / Files / Explore / Peers" into "Open IPFS Desktop" or something similar. Does this work for you?

image

@hacdias
Copy link
Member Author

hacdias commented Mar 12, 2019

@ericronne or "Open Web UI". But that'd be better to check with everyone 😄This is just an experiment, although it seems to be working well.

@ericronne
Copy link

Ah, taxononmy! (shakes fist)

@hacdias hacdias mentioned this issue Mar 12, 2019
1 task
@ghost ghost assigned hacdias Mar 12, 2019
@ghost ghost added the in progress label Mar 12, 2019
@ghost ghost removed the in progress label Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants