-
Notifications
You must be signed in to change notification settings - Fork 875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to menubar menu only #865
Comments
On macOS it's not rare a menubar app having different actions for click, although I can agree that most users may be unaware of that capability. Would the right click actions be aggregated somehow in the menubar? |
@fsdiogo no, it would be the opposite way: just have the native menubar. It would be just simpler for everyone. @lidel here's one on macOS: #857 (comment): |
In conversation with @ericronne it came up that the menubar UI was mostly still there becuase this app started life as a menubar app, and then we changed course. I am in favour of using a system menubar (like the docker example above) for simplicity, and to make it feel more like a native app, and to remove the left/right click distinction, where left clicks gets you a fancy menu, and right click gets you a system menu with different options Current right click menu in IPFS Desktop |
A possible idea of what it could be (options would need to be tweaked): We could mimic the status in the top as Docker Desktop do. We could perhaps hide the versions on a sub menu or About dialog. And perhaps hiding "Configuration folder", "logs directory" and eventually "IPFS repository" under advanced sub menu. |
Oh ok, wasn't expecting that to be honest 😮 Well, it kind of makes sense as right now we don't get that much with the menu bar app, being Web UI the central point of it, so I think it's ok just having a native menu. I'm up for it 👍 |
@fsdiogo yeah, it might be a little sad (and I trully feel it since I've been working on this for a long time haha), but it just gets a better native feeling and simplifies everything |
This is what I've been working for the last hour. Just to try it out. It would work. We'd still use Electron. It looks more native on macOS than on Windows because Chromium never used Windows' native context menu. But I don't believe that'd be an issue. Yes, the color icon is not aligned/with the correct size. I wonder if in the future we could ditch Electron and find a way to create a menubar without the heavy baggage that Electron is. What do you think about this? |
@ericronne or "Open Web UI". But that'd be better to check with everyone 😄This is just an experiment, although it seems to be working well. |
Ah, taxononmy! (shakes fist) |
Most menubar apps have the same behaviour when using the right or left click and right now we have different actions for both. On left click, we open the real React menubar and with the right click we option a native menu with some options.
Since this goes against what most do, probably people would get confused and we thought about moving it only to a menubar menu app. With this we could simplify the user experience (on all OSes) and reduce lots of dependencies we need right now.
/cc @ipfs-shipyard/gui
The text was updated successfully, but these errors were encountered: