Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update zh-TW locales #1351

Closed
wants to merge 1 commit into from
Closed

Conversation

bluelovers
Copy link
Contributor

No description provided.

@lidel
Copy link
Member

lidel commented Feb 20, 2020

Thank you for contributing translation @bluelovers !

To avoid duplicated work, we don't accept direct PRs with locales.
Please submit translations using Transifex project at https://www.transifex.com/ipfs/ipfs-desktop/

(Let me know your Transifex account name, I will add you to the zh-TW translation team)

We synchronize translations with Transifex before each release, as you can see in #1347.
You can find more information at /docs/localization-notes.md and ipfs/i18n.

@lidel lidel closed this Feb 20, 2020
@bluelovers
Copy link
Contributor Author

bluelovers commented Feb 20, 2020

hmm, i think need fix link in readme

Transifex link in readme is 404 or maybe it is private only, that is why i use pr

@lidel
Copy link
Member

lidel commented Feb 20, 2020

@bluelovers which link returned 404 for you?
https://www.transifex.com/ipfs/ipfs-desktop/ is public and works fine

@bluelovers
Copy link
Contributor Author

@lidel
Copy link
Member

lidel commented Feb 20, 2020

@bluelovers wow this is interesting, for me the /translate link redirects to the login page at https://www.transifex.com/signin/?next=/ipfs/ipfs-desktop/translate/

Are you able to check if you can login via above link?
Do you get 404 after successful login to your Transifex account?

@bluelovers
Copy link
Contributor Author

login and logout both is 404 at that link

@lidel
Copy link
Member

lidel commented Feb 21, 2020

@bluelovers very odd. Are you behind The Great Firewall of China?

@bluelovers
Copy link
Contributor Author

@lidel
Copy link
Member

lidel commented Feb 21, 2020

@bluelovers
Copy link
Contributor Author

i think is not, it redirect to
https://www.transifex.com/nodebb/nodebb/dashboard/

@lidel
Copy link
Member

lidel commented Feb 22, 2020

@bluelovers try logging out of Transifex and logging in again, then open https://www.transifex.com/ipfs/ipfs-desktop/translate/
You should have access to zh-TW now (I've added you to translation team)

@bluelovers
Copy link
Contributor Author

https://www.transifex.com/ipfs/ipfs-desktop/translate/ this link only work when add into team

@lidel
Copy link
Member

lidel commented Feb 25, 2020

Ah.. yes, that is what was missing.
Thank you for your patience and contributions!

@bluelovers
Copy link
Contributor Author

other ipfs readme has same issue too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants