Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(un): decouple webui [META] [THOUGHT] #1413

Closed
wants to merge 2 commits into from
Closed

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Apr 17, 2020

See #1389.

This is my attempt at decoupling IPFS Desktop from Web UI. It is not finished and I won't work more on it unless we all agree we should move forward on this.

This basically removes the Web UI window and when you click 'Status' or 'Files' you're just pointed to your default browser, opening the Web UI.

image

The Preferences (or Settings for non-macOS users) are all checkboxes. Clicking on them should be enough to enable or disable them. Some (not implemented) should show a dialog explaining what they actually do and ask the user if they really want to proceed.

On the Web UI side, a lot of simplifications can be made with this!

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@hacdias
Copy link
Member Author

hacdias commented Apr 17, 2020

@lidel @jessicaschilling @autonome I would love your input on this 😃

@hacdias hacdias mentioned this pull request Apr 17, 2020
22 tasks
@jessicaschilling
Copy link
Contributor

Thought: Regardless of the degree to which we do/don't kill off the Electron standalone window in favor of moving into the browser -- moving those desktop-only settings out of the "Settings" screen and into the menubar makes a lot of sense. There's some linguistic stuff that probably needs to be refined (basically, we need to be explicitly clear about when "settings" means "IPFS config" and when it means "app settings"), but overall this makes a ton of sense, particularly for people who switch between Desktop and WebUI: right now we are giving them two different settings screens and that makes it really hard to remember where you do what.

If we do go in the direction of "IPFS Desktop" really just meaning "IPFS Menubar App", this sort of implies that we're committing to the path of OS integration over standalone apps ... which I'm all in favor of, and in any case matches industry trends for cloud file sharing. This sounds fantastic on the surface, but maybe we want to have a dedicated conversation about this as whether it is, indeed, our strategic direction.

@lidel
Copy link
Member

lidel commented Apr 18, 2020

Quick feedback: keep PRs small. Easier to discuss, easier to review, less mistakes :)

  • limit the scope of this PR to the Settings cleanup
    • focus on decoupling ipfs-desktop's Settings from ipfs-webui screen and moving them to intuitive menu items
    • keep bundling ipfs-webui and keep opening it in Electron for now
      (switching to browser should be separate PR)
  • menu actions that are ON/OFF should indicate clear action (start with verb?):
    • examples: "Enable npm-on-ipfs", "Enable command line tools" etc

@hacdias
Copy link
Member Author

hacdias commented Apr 18, 2020

@lidel that's actually what I thought after doing this haha. I'm going to do another PR with the preferences section only then!

@hacdias
Copy link
Member Author

hacdias commented Apr 18, 2020

I'll close this PR.

@hacdias hacdias closed this Apr 18, 2020
@hacdias hacdias deleted the feat/decouple-webui branch April 18, 2020 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants