Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable PUBSUB experiment by default #1649

Closed
wants to merge 1 commit into from

Conversation

shaikh-shahid
Copy link

This is a known and request feature. I don't mind if its released under a branch but lots of people require PUBSUB enabled by default. So here is PR.

This is a known and request feature. I don't mind if its released under a branch but lots of people require PUBSUB enabled by default. So here is PR.
@ipfs ipfs deleted a comment from welcome bot Sep 18, 2020
@jessicaschilling
Copy link
Contributor

Thanks, @shaikh-shahid! We've got this queued up to discuss in our next weekly triage.

@shaikh-shahid
Copy link
Author

Awesome @jessicaschilling . Hope it gets merged :)

@jessicaschilling
Copy link
Contributor

We've actually got this going under #1647 as part of adding menu items for this and automatic garbage collection -- would you be interested in augmenting your PR to meet that issue's needs?

@shaikh-shahid
Copy link
Author

Sure @jessicaschilling . Actually I made that suggestion in the PR. I need bit of help in the UI end.

@jessicaschilling
Copy link
Contributor

Thanks, @shaikh-shahid! Added a quick mockup of menu item placement in original comment here -- does that give you what you need to get started?

@shaikh-shahid
Copy link
Author

Yes, that helps @jessicaschilling . I am currently working on this feature, will submit a PR ASAP. If there is any blocker will surely let you know.

@lidel lidel marked this pull request as draft October 7, 2020 20:33
@lidel lidel changed the title Enable PUBSUB experiment by default feat: enable PUBSUB experiment by default Oct 7, 2020
@olizilla
Copy link
Member

I just tried to enable pubsub on desktop and it was hard! I would love a button that let me enable pubsub, and would be totally up for enabling pubsub by default.

@jessicaschilling
Copy link
Contributor

Closing as superseded by #1735.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants