fix: print useful error on write fail #1843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This displays error details when write to a destination directory fails, and ensures stored files are contained within destination dir. License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
schomatis
reviewed
Jun 16, 2021
schomatis
approved these changes
Jun 17, 2021
This makes a safer default, as won't silently overwrite user data, forcing user to pick an empty dir for destination and handle any conflict reesolution manually. License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This displays error details when write to a destination directory fails, and ensures stored files are contained within destination dir.
Should improve UX in situations where user picked read-only directory, run out of disk space etc.
cc @schomatis