Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: smaller dep updates #1959

Merged
merged 2 commits into from
Jan 21, 2022
Merged

chore: smaller dep updates #1959

merged 2 commits into from
Jan 21, 2022

Conversation

lidel
Copy link
Member

@lidel lidel commented Jan 21, 2022

This bumps another set of dependencies. (part of release prep)

TODO

  • security patch of Electron 13.x
  • decrease trust in semver on NPM because fool me 4 times..
  • there is a bug when (1) npm start initializes a new repo (2) quit (3) npm start fails to start daemon correctly, webui is displayed in offline state
    • i confirmed this is a regression introduced by chore: update ipfs deps #1899 – perhaps ipfsd-ctl bug?
    • seems that the problem is that when ipfs-desktop quits it force-kills go-ipfs in a way that leaves ~/.ipfs/api around.
    • before chore: update ipfs deps #1899 [daemon] removing api file worked fine (after confirming that multiaddr in api is from the local daemon who is offline, and not a remote node) – I suspect adding ERR_CONNECTION_REFUSED check introduced a bug, probably invalid condition
    • yep that's it, fix in 1f4846e

This fixes regression introduced by #1899
@lidel lidel marked this pull request as ready for review January 21, 2022 03:11
@lidel lidel requested a review from hacdias January 21, 2022 03:12
@@ -79,7 +79,7 @@ module.exports = async function (opts) {
logger.info(`[daemon] PeerID is ${id}`)
logger.info(`[daemon] Repo is at ${ipfsd.path}`)
} catch (err) {
if (!err.message.includes('ECONNREFUSED') || !err.message.includes('ERR_CONNECTION_REFUSED')) {
if (!err.message.includes('ECONNREFUSED') && !err.message.includes('ERR_CONNECTION_REFUSED')) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pixel-cat-salute

@lidel lidel merged commit 3b13847 into main Jan 21, 2022
@lidel lidel deleted the chore/patch-updates branch January 21, 2022 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant