Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: detect invalid or corrupted repository #2067

Merged
merged 4 commits into from
Mar 25, 2022
Merged

fix: detect invalid or corrupted repository #2067

merged 4 commits into from
Mar 25, 2022

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Mar 24, 2022

Fixes #2050

image

@hacdias hacdias marked this pull request as ready for review March 24, 2022 11:04
@hacdias hacdias requested a review from lidel March 24, 2022 11:04
@hacdias hacdias marked this pull request as draft March 24, 2022 11:08
@hacdias
Copy link
Member Author

hacdias commented Mar 24, 2022

I wanted to add E2E tests but I couldn't find a way to interact with native dialogs from Electron.

@hacdias hacdias marked this pull request as ready for review March 24, 2022 11:34
on linux we show webui on startup because tray icon is not always
available, and showDialog's blocking nature freezes it mid-load.

What is worse, that broken BrowserWindow may be on top of the dialog,
leaving user confused why everything froze.

This solves the problem by hiding all windows before showing the final
dialog
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I am afraid there is no way of testing this automatically.

  • Tweaked message a bit
  • Added small fix for Linux in 6a64e98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add UI to fix invalid .ipfs or .ipfs/config
2 participants