fix: return error instead of throw

[hacdias]

Fixes #2069

License: MIT
Signed-off-by: Henrique Dias hacdias@gmail.com

[lidel]

Could be me not understanding how to test this, but it does not seem to work as expected.

If I create .ipfs/api with /ip4/127.0.0.1/tcp/5006 and then start npx serve -l 5006 to simulate non-HTTP service on that port, and then try to start ipfs-desktop, I see no error.

Electron window with ipfs-webui is displayed in broken state and [ipfsd] start daemon HTTPError: is logged to the console, but no dialog is displayed to the user.

[hacdias]

@lidel can you try on main? Because that also doesn't trigger an error on main for me. The problem seems to be more profound. We need to display a nice dialog when there is an error starting the daemon. The problem right now is that different errors are handled in different ways.

The original issue (#2069) is that the user is running something on IPFS Gateway / API port already. In that case, IPFS Desktop will ask you to change a port or not. If you decided not to change, IPFS Desktop would close even though we handled the situation gracefully. It's not about having a remote API.

We have to see if what is missing here is a dialog saying that IPFS failed to start, or keep just letting IPFS Desktop fail with the default dialog.

[hacdias]

Ping @lidel

[lidel]

For some reason, I was under the impression this PR introduced regression around API port, but if the behavior was the same in main then fine merge this. API issues are separate things, need separate issues/PRs if they are a real problem (seems no?)