Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: js-ipfsd-ctl daemon-remote #549

Merged
merged 3 commits into from
Jan 16, 2018
Merged

feat: js-ipfsd-ctl daemon-remote #549

merged 3 commits into from
Jan 16, 2018

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Dec 20, 2017 •
edited
Loading

WIP

Depends on: ipfs/js-ipfsd-ctl#176

  • Update on package.json ipfsd-ctl version.

@daviddias daviddias changed the title [WIP] feat: js-ipfsd-ctl daemon-remote feat: js-ipfsd-ctl daemon-remote Dec 20, 2017
@daviddias daviddias mentioned this pull request Dec 20, 2017
Merged
6 tasks
@hacdias
Copy link
Member Author

hacdias commented Dec 21, 2017 •
edited
Loading

@victorbjelkholm the Linux build is failing on Jenkins since we now need to install libssl-dev so we can build the native dependencies of js-ipfsd-ctl. Can you add that to Jenkins?

Same thing on macOS. Can that be also installed in there?

The Windows build is failing due to some error I couldn't figure out yet.

Build's working 😄

@hacdias hacdias mentioned this pull request Dec 21, 2017
Merged
@hacdias hacdias force-pushed the ipfsd-ctl-update branch 4 times, most recently from 69994fd to a5afab7 Compare December 26, 2017 18:39
@daviddias
Copy link
Member

@hacdias make sure to update your comment above to reflect the actual needs. If I understand correctly, libssl-dev won't be needed after all, correct?

@hacdias
Copy link
Member Author

hacdias commented Dec 27, 2017

Done @diasdavid

victorb
victorb approved these changes Dec 27, 2017
View reviewed changes
package.json Outdated
"ipfs-geoip": "^2.3.0",
"ipfsd-ctl": "^0.26.0",
"ipfsd-ctl": "ipfs/js-ipfsd-ctl#feat/remote-daemon",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should point this to a commit directly instead of a branch. Branches sometimes gets deleted when PRs are merged, or mutates in general. Pointing to the commit prevents those things from having a bad impact.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@victorbjelkholm I'll update this to the right version as soon as it is released and before merging 😄

@hacdias hacdias mentioned this pull request Jan 11, 2018
Merged
3 tasks
@daviddias
Copy link
Member

image

@hacdias as a note for the future, target to always do rebase instead of merge commits.

@hacdias
Copy link
Member Author

hacdias commented Jan 11, 2018

Sure!

@daviddias
Copy link
Member

ipfsd-ctl 0.27 has been published. Could you update the PR and rebase master to resolve merge conflicts?

@hacdias hacdias merged commit 8d7b93d into master Jan 16, 2018
@hacdias hacdias deleted the ipfsd-ctl-update branch January 16, 2018 15:26
This was referenced Apr 4, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorb victorb victorb approved these changes

@daviddias daviddias Awaiting requested review from daviddias

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hacdias @daviddias @victorb