feat: enable gc #826
Merged
feat: enable gc #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
ghost
assigned
9 tasks
lidel
approved these changes
Feb 16, 2019
There was a problem hiding this comment.
LGTM!
For the record, it will enable GC with default settings.
In go-ipfs v0.4.18 those are:
https://github.com/ipfs/go-ipfs/blob/v0.4.18/docs/config.md#datastore:
StorageMax
A soft upper limit for the size of the ipfs repository's datastore. WithStorageGCWatermark,
is used to calculate whether to trigger a gc run (only if--enable-gcflag is set).Default:
10GB
StorageGCWatermark
The percentage of theStorageMaxvalue at which a garbage collection will be
triggered automatically if the daemon was run with automatic gc enabled (that
option defaults to false currently).Default:
90
GCPeriod
A time duration specifying how frequently to run a garbage collection. Only used
if automatic gc is enabled.Default:
1h
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #665, let's enable automatic garbage collector.
License: MIT
Signed-off-by: Henrique Dias hacdias@gmail.com