feat: add 'ipfs' to PATH on Windows #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
ghost
assigned 
hacdias
changed the title
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
hacdias
changed the title
|
I encountered an unrelated issue with |
|
Per @djdv feedback, I'm merging this PR 😄 Thanks for checking it out. |
This was referenced Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During installation, append
ipfs-desktop/assets/bin-winto thePATHon Windows. It's also removed during installation. The directory contains a script that executes our bin script that redirects the arguments to the actual binary. That way we have some flexibility about what we can do in the future.The code used to manipulate the
PATHcomes from this resources:Also, I had to disable "warnings as errors" because Electron Builder is using Macros for custom install and uninstall sections so when building the installer, NSIS didn't know if we were calling the functions in the correct places. It threw a warning that was treated as an error. Not anymore.
Addresses #727.