Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files: shared link should include filename #1346

Closed
lidel opened this issue Dec 3, 2019 · 0 comments · Fixed by #1347
Closed

Files: shared link should include filename #1346

lidel opened this issue Dec 3, 2019 · 0 comments · Fixed by #1347
Assignees
Labels
exp/novice Someone with a little familiarity can pick up topic/design-front-end Front-end implementation of UX/UI work topic/design-ux UX strategy, research, not solely visual design

Comments

@lidel
Copy link
Member

lidel commented Dec 3, 2019

See also #1327, ipfs/ipfs-companion#810

Motivation

"Share" feature returns a direct CID link to file at gateway, which means filename is lost:

2019-12-03--21-39-23

The link provided for copying is for RAW CID: https://ipfs.io/ipfs/QmZm53emWPQGQivin6GGT24E2xvzqd56444W881sa7pjqu:

popup-2019-12-03--21-38-59

Fix

One way is to create a wrapping directory, and embedd filename in it, however a more efficient way is to take advantage of ?filename= parameter supported by go-ipfs and js-ipfs:

https://ipfs.io/ipfs/QmZm53emWPQGQivin6GGT24E2xvzqd56444W881sa7pjqu?filename=name-from-webui.png

This does not produce any overhead, and persists filename in browser history and if user decides to save it to disk.

(Just make sure unicode string is url-escaped)

@lidel lidel added exp/novice Someone with a little familiarity can pick up topic/design-front-end Front-end implementation of UX/UI work topic/design-ux UX strategy, research, not solely visual design labels Dec 3, 2019
@lidel lidel self-assigned this Dec 3, 2019
lidel added a commit that referenced this issue Dec 3, 2019
lidel added a commit that referenced this issue Dec 3, 2019
hacdias pushed a commit that referenced this issue Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/novice Someone with a little familiarity can pick up topic/design-front-end Front-end implementation of UX/UI work topic/design-ux UX strategy, research, not solely visual design
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant