Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gateway missing translations.json #1395

Closed
ggarri opened this issue Feb 6, 2020 · 1 comment · Fixed by #1515 or #1516
Closed

Gateway missing translations.json #1395

ggarri opened this issue Feb 6, 2020 · 1 comment · Fixed by #1515 or #1516

Comments

@ggarri
Copy link

ggarri commented Feb 6, 2020

  • Version:
    js-ipfs version: 0.40.0-
    Repo version: 7
    System version: x64/linux
    Node.js version: v11.15.0
  • Platform: Linux 4.15.0-72-generic Error handling component #81-Ubuntu SMP x86_64 x86_64 x86_64 GNU/Linux
  • Subsystem: webui

Type: Bug

Severity: Very Low

Description:

Gateway dashboard UI cannot be translated to other than English. Translation snippets appear to be requested but missing.

Steps to reproduce the error:

Screenshot

image
@ggarri ggarri mentioned this issue Feb 6, 2020
Closed
@bertrandfalguiere bertrandfalguiere mentioned this issue May 27, 2020
Closed
@lidel lidel mentioned this issue Jun 4, 2020
Merged
@lidel
Copy link
Member

lidel commented Jun 4, 2020

Note to self: we don't use that file, but:

i18next per default loads it translations from one file named translation.json
https://www.i18next.com/principles/fallback

Changing the default namespace to app (defaultNS: 'app' in init) might remove unnecessary request.

lidel added a commit that referenced this issue Jun 4, 2020
@lidel
fix(i18n): use app.json for fallback
7d986df 
default was translation.json, which does not exist, and always failed

closes #1395
@lidel lidel mentioned this issue Jun 4, 2020
Merged
lidel added a commit that referenced this issue Jun 4, 2020
@lidel
fix(i18n): restoring translation of remaining strings (#1516)
07ed735 
fix(i18n): explicit t={t} in <Trans tags

Perhaps there is more elegant way to do this,
but by explicitly passing t we ensure everything works, no matter
if page is a separate module or if translations did not load yet.
closes #1370


fix(i18n): use app.json for fallback

default was translation.json, which does not exist, and always failed
closes #1395


fix(i18n): paragraoh2 → paragraph2 
typo in .json files blocked translation from being properly loaded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@lidel @ggarri