Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX Bug: Add folder action is hidden behind "import" dropdown button #1951

Open
SgtPooki opened this issue Jun 20, 2022 · 6 comments
Open

UX Bug: Add folder action is hidden behind "import" dropdown button #1951

SgtPooki opened this issue Jun 20, 2022 · 6 comments
Labels
area/screen/files Issues related to Files screen effort/hours Estimated to take one or several hours exp/beginner Can be confidently tackled by newcomers kind/bug A bug in existing code (including security flaws) P3 Low: Not priority right now status/ready Ready to be worked topic/design-front-end Front-end implementation of UX/UI work topic/design-ux UX strategy, research, not solely visual design topic/design-visual Visual design ONLY, not part of a larger UX effort

Comments

@SgtPooki
Copy link
Member

SgtPooki commented Jun 20, 2022

Describe the bug
"New folder" behind "Import" doesn't make sense. You can't import something that doesn't exist yet, but you can create it. "Add" instead of "Import" makes the most sense for all of the cases.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Files screen
  2. Click on 'Import'
  3. Notice that 'New Folder' is listed as an option under "Import"

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
image

Desktop (please complete the following information):
IPFS Desktop on macOS Monterey 12.4 (21F79)

UI v2.15.0
Revision fadd900
See the code
Report a bug

Additional context
N/A

@SgtPooki SgtPooki added kind/bug A bug in existing code (including security flaws) help wanted Seeking public contribution on this issue P3 Low: Not priority right now status/ready Ready to be worked area/screen/files Issues related to Files screen topic/design-visual Visual design ONLY, not part of a larger UX effort need/triage Needs initial labeling and prioritization good first issue Good issue for new contributors exp/beginner Can be confidently tackled by newcomers effort/hours Estimated to take one or several hours labels Jun 20, 2022
@SgtPooki SgtPooki removed the need/triage Needs initial labeling and prioritization label Jun 27, 2022
@SgtPooki SgtPooki added topic/design-front-end Front-end implementation of UX/UI work topic/design-ux UX strategy, research, not solely visual design and removed help wanted Seeking public contribution on this issue good first issue Good issue for new contributors labels Jul 7, 2022
@SgtPooki
Copy link
Member Author

SgtPooki commented Jul 7, 2022

@juliaxbow, we discussed this in our GUI triage meeting, and @lidel mentioned that "Import" was added in the past because it made the most sense for all of the options other than "New Folder". What do you think makes the most sense for this screen?

@juliaxbow
Copy link
Collaborator

@SgtPooki I'd recommend switching over to "Add," as suggested, or "New," which you'll see on some other file sharing platforms. I'm leaning towards "New" but defer to you on current user flow. Let me know if you want me to conduct some quick tests.

I would also recommend:

  • Modifying icons slightly to show upload vs new folder creation
  • Rename actions for clarity (e.g. "File Upload" or "File Import" vs "File")
  • Adding a line to differentiate between actions (upload vs create)

Screenshot attached for reference.
Import Dropdown

@SgtPooki
Copy link
Member Author

@lidel what do you think about the proposals from Julia?

@SgtPooki SgtPooki moved this from Todo to UX design needed in IPFS-GUI (PL EngRes) Jul 18, 2022
@lidel
Copy link
Member

lidel commented Aug 9, 2022

I think both are 👍 thank you, @juliaxbow!

@SgtPooki SgtPooki moved this from UX design needed to Planned in IPFS-GUI (PL EngRes) Oct 7, 2022
@SgtPooki
Copy link
Member Author

SgtPooki commented Oct 7, 2022

Ok so next steps:

  1. change button to "Add"
  2. Change items to "File Import", "Folder Import", "IPFS Import", and "New Folder"
  3. Ensure any icons we use are in https://github.com/ipfs-shipyard/ipfs-css#icons

@juliaxbow
Copy link
Collaborator

juliaxbow commented Oct 7, 2022

Added the new icons under doc_text_import and folder_import !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/screen/files Issues related to Files screen effort/hours Estimated to take one or several hours exp/beginner Can be confidently tackled by newcomers kind/bug A bug in existing code (including security flaws) P3 Low: Not priority right now status/ready Ready to be worked topic/design-front-end Front-end implementation of UX/UI work topic/design-ux UX strategy, research, not solely visual design topic/design-visual Visual design ONLY, not part of a larger UX effort
Projects
No open projects
Status: Planned / Backlog
Development

No branches or pull requests

3 participants