-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webui.ipfs.io is not updated to the latest version #2021
Comments
@SgtPooki : how do we prevent this from happening in the future and catch if it does? |
@BigLep it should have already been caught. I must have broken something with the release updates that I've done over the past month or two. The release workflow for v2.18.0 is at https://github.com/ipfs/ipfs-webui/actions/runs/3025892693 |
Yep, it looks like I missed an if statement in the ci.yml workflow: ipfs-webui/.github/workflows/ci.yml Lines 138 to 148 in fe4ef00
If you look at dev.webui.ipfs.io, it's updated with the latest commit: fe4ef00, but the prod DNSlink was not updated; the step itself was just skipped. |
After #2024 is merged, we won't run into this issue again |
@lidel I can fix the dnslink if given access to the DNSIMPLE_TOKEN (it's not in our shared password vault) |
running ci.yml: https://github.com/ipfs/ipfs-webui/actions/runs/3048111224 |
## [2.18.1](v2.18.0...v2.18.1) (2022-09-13) CID `bafybeiageaoxg6d7npaof6eyzqbwvbubyler7bq44hayik2hvqcggg7d2y` --- ### Bug Fixes * show '0 B' instead of '-' for zero-length files ([#2018](#2018)) ([fda3bf5](fda3bf5)) * update webui.ipfs.io dnslink on manual release ([#2024](#2024)) ([0f1e1c2](0f1e1c2)), closes [#2021](#2021) ### Tests * add playwright code coverage ([#2014](#2014)) ([0ecc822](0ecc822)) ### Trivial Changes * pull transifex translations ([#2019](#2019)) ([5e59065](5e59065)) * **readme:** correct IPFS Desktop release link ([b76c0db](b76c0db)) * remove unused dependencies ([#2015](#2015)) ([f007d78](f007d78))
🎉 This issue has been resolved in version 2.18.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
webui.ipfs.io is showing 5e59065 as the latest revision. |
Seems we have a regression, publishing v2.18.0 did not update DNSLink at https://webui.ipfs.io:
The text was updated successfully, but these errors were encountered: