Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webui.ipfs.io is not updated to the latest version #2021

Closed
lidel opened this issue Sep 12, 2022 · 9 comments · Fixed by #2024
Closed

webui.ipfs.io is not updated to the latest version #2021

lidel opened this issue Sep 12, 2022 · 9 comments · Fixed by #2024
Assignees
Labels
kind/bug A bug in existing code (including security flaws) kind/maintenance Work required to avoid breaking changes or harm to project's status quo P1 High: Likely tackled by core team if no one steps up released

Comments

@lidel
Copy link
Member

lidel commented Sep 12, 2022

Seems we have a regression, publishing v2.18.0 did not update DNSLink at https://webui.ipfs.io:

@lidel lidel added kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up kind/maintenance Work required to avoid breaking changes or harm to project's status quo labels Sep 12, 2022
@BigLep
Copy link

BigLep commented Sep 12, 2022

@SgtPooki : how do we prevent this from happening in the future and catch if it does?

@SgtPooki
Copy link
Member

@BigLep it should have already been caught. I must have broken something with the release updates that I've done over the past month or two. The release workflow for v2.18.0 is at https://github.com/ipfs/ipfs-webui/actions/runs/3025892693

@SgtPooki
Copy link
Member

Yep, it looks like I missed an if statement in the ci.yml workflow:

# dev dnslink is updated on each main branch update
- run: npx dnslink-dnsimple --domain dev.webui.ipfs.io --link /ipfs/${{ steps.ipfs.outputs.cid }}
if: github.ref == 'refs/heads/main'
env:
DNSIMPLE_TOKEN: ${{ secrets.DNSIMPLE_TOKEN }}
# production dnslink is updated on release (during tag build)
- run: npx dnslink-dnsimple --domain webui.ipfs.io --link /ipfs/${{ steps.ipfs.outputs.cid }}
if: startsWith(github.ref, 'refs/tags/v')
env:
DNSIMPLE_TOKEN: ${{ secrets.DNSIMPLE_TOKEN }}

If you look at dev.webui.ipfs.io, it's updated with the latest commit: fe4ef00, but the prod DNSlink was not updated; the step itself was just skipped.

@SgtPooki
Copy link
Member

After #2024 is merged, we won't run into this issue again

@SgtPooki
Copy link
Member

@lidel I can fix the dnslink if given access to the DNSIMPLE_TOKEN (it's not in our shared password vault)

@lidel
Copy link
Member Author

lidel commented Sep 13, 2022

@SgtPooki I think there is no point in spending time on manual fix.
Better do a patch release (i merged #2019) and smoke test fix from #2024

@SgtPooki
Copy link
Member

ipfs-gui-bot pushed a commit that referenced this issue Sep 13, 2022
## [2.18.1](v2.18.0...v2.18.1) (2022-09-13)

 CID `bafybeiageaoxg6d7npaof6eyzqbwvbubyler7bq44hayik2hvqcggg7d2y`

 ---

### Bug Fixes

* show '0 B' instead of '-' for zero-length files ([#2018](#2018)) ([fda3bf5](fda3bf5))
* update webui.ipfs.io dnslink on manual release ([#2024](#2024)) ([0f1e1c2](0f1e1c2)), closes [#2021](#2021)

### Tests

* add playwright code coverage ([#2014](#2014)) ([0ecc822](0ecc822))

### Trivial Changes

* pull transifex translations ([#2019](#2019)) ([5e59065](5e59065))
* **readme:** correct IPFS Desktop release link ([b76c0db](b76c0db))
* remove unused dependencies ([#2015](#2015)) ([f007d78](f007d78))
@ipfs-gui-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 2.18.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@SgtPooki
Copy link
Member

webui.ipfs.io is showing 5e59065 as the latest revision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws) kind/maintenance Work required to avoid breaking changes or harm to project's status quo P1 High: Likely tackled by core team if no one steps up released
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants