Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show file operations and meta info on file preview page #813

Closed
olizilla opened this issue Sep 25, 2018 · 1 comment
Closed

Show file operations and meta info on file preview page #813

olizilla opened this issue Sep 25, 2018 · 1 comment
Assignees
@fsdiogo
Labels
exp/intermediate Prior experience is likely helpful

Comments

@olizilla
Copy link
Member

When I want to share a file, it feel natural to click on it. This opens up the file preview page, which shows the path and the file, but the actions aren't available.

file actions
screenshot 2018-09-25 15 29 51

file preview
screenshot 2018-09-25 15 29 56

It'd be great to still have access to:

  • Share
  • Download
  • Delete
  • inspect
  • Rename

along with info like

  • file CID
  • file size
  • assumed file type / file icon
@olizilla olizilla added exp/intermediate Prior experience is likely helpful status/ready Ready to be worked labels Sep 25, 2018
@olizilla olizilla mentioned this issue Jan 11, 2019
Closed
10 tasks
@fsdiogo
Copy link
Contributor

fsdiogo commented Jan 11, 2019

Dropbox does it like this:

dropbox

I sketched out two proposals:

1. I like the cleanliness of this one 2. Shameless Dropbox copy
proposal-1 proposal-2

What do you guys think? @ipfs-shipyard/gui

@fsdiogo fsdiogo self-assigned this Jan 14, 2019
@fsdiogo fsdiogo added status/in-progress In progress and removed status/ready Ready to be worked labels Jan 14, 2019
@fsdiogo fsdiogo mentioned this issue Jan 16, 2019
Merged
fsdiogo added a commit that referenced this issue Jan 24, 2019
@fsdiogo
feat: add file operations in preview (#936)
6926e40 
![preview](https://user-images.githubusercontent.com/33324750/51191990-74ec6800-18dd-11e9-877c-2779c2fd56f7.gif)

Closes #813.
@ghost ghost removed the status/in-progress In progress label Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fsdiogo fsdiogo

Labels
exp/intermediate Prior experience is likely helpful
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@olizilla @fsdiogo