Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smart API detection when loaded from non-standard API port in go-ipfs #837

Closed
lidel opened this issue Sep 28, 2018 · 2 comments · Fixed by #845
Closed

Smart API detection when loaded from non-standard API port in go-ipfs #837

lidel opened this issue Sep 28, 2018 · 2 comments · Fixed by #845

Comments

@lidel
Copy link
Member

lidel commented Sep 28, 2018

This is something came to me when I was looking at ipfs/js-ipfs#1595 and #785.

If go-ipfs runs API on a different port than :5001, then webui will not be able to connect to it, even tho it was loaded from the API port 🙃

Instead, it will display error page where user needs to manually provide the port.

Its not bad, and may be enough for now, however I feel we could make it work automatically:

I think (B) makes more sense, it would fix the issue for both go-ipfs and js-ipfs without adding any cruft to URL.

@olizilla thoughts?

@olizilla
Copy link
Member

@lidel oh my yes! B is a very good idea.

@olizilla
Copy link
Member

olizilla commented Oct 2, 2018

First pass of this is in ipfs-inactive/ipfs-redux-bundle#15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants