This repository has been archived by the owner on Oct 16, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6
chore: test bundle code rather than all of ipfs #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
its very mock heavy, but our code depends on _all_ the possible ways of connecting to ipfs, our tests become horrible without some judicious mocking out of dependencies. It means we can now focus our tests on the logic of this module rather than elaborate ipfs init tests. Also our tests no longer fail if you happen to be running an ipfs daemon which is nice. Also adds option to try accessing ipfs directly from companion seperate from window.ipfs, and will try js-ipfs-api on the current origin before trying the default value License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
olizilla
changed the title
[WIP] split out and test provider logic
chore: test bundle code rather than all of ipfs
Oct 2, 2018
Fixes #4 as it now uses an |
This was referenced Oct 2, 2018
License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
1 task
lidel
approved these changes
Oct 2, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with ipfs/ipfs-webui#845 and works as advertised :)) 👍
hacdias
approved these changes
Oct 3, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😄
fsdiogo
approved these changes
Oct 3, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
its very mock heavy, but our code depends on all the possible
ways of connecting to ipfs; our tests become horrible without some
judicious mocking out of dependencies.
It means we can now focus our tests on the logic of this module
rather than elaborate ipfs init tests. Also our tests no longer
fail if you happen to be running an ipfs daemon which is nice.
Also adds option to try accessing ipfs directly from companion
seperate from window.ipfs, and will try js-ipfs-api on the current
origin before trying the default value
License: MIT
Signed-off-by: Oli Evans oli@tableflip.io