Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files: make it easier to create a new folder #915

Closed
lidel opened this issue Dec 20, 2018 · 3 comments
Closed

Files: make it easier to create a new folder #915

lidel opened this issue Dec 20, 2018 · 3 comments
Assignees
Labels
kind/discussion Topical discussion; usually not changes to codebase

Comments

@lidel
Copy link
Member

lidel commented Dec 20, 2018

A lot of "file management" starts with creating a new folder and moving things to it.
Right now "New folder" action is hidden under "Add to IPFS" button and hard to discover and requires 2 clicks instead of one.

What if we make it a top-level button (in faded out, much less prominent colors than "Add to IPFS")?

2018-12-20--11-21-43

Thoughts?

@olizilla
Copy link
Member

Yep, it's confusing to have "new folder" in the same list. I'd like to do some design exploration on what we can do to make the "add to IPFS" process much better. "Add by path" is confusing for new users and it sound like "file system path", so I think we need to re-think this menu entirely.

@lidel
Copy link
Member Author

lidel commented Jan 6, 2019

Indeed, "Add by path" suggests something is not on IPFS and needs to be added, while all it does it import of existing IPFS data to MFS.

I guess it could also be moved to top-level, and/or renamed to something like "Import IPFS path".

@olizilla olizilla mentioned this issue Jan 7, 2019
10 tasks
@fsdiogo
Copy link
Contributor

fsdiogo commented Jan 9, 2019

Dropbox doesn't use dropdowns, all options are visible:

dropbox

Google Drive is similar to the current Web UI, it gathers everything under a dropdown:

gdrive


I agree we should think about how to improve this menu and the overall experience of dragging and dropping files on the Web UI.

@fsdiogo fsdiogo added the kind/discussion Topical discussion; usually not changes to codebase label Jan 11, 2019
@fsdiogo fsdiogo self-assigned this Feb 1, 2019
@fsdiogo fsdiogo added the status/in-progress In progress label Feb 1, 2019
fsdiogo added a commit that referenced this issue Feb 6, 2019
As per #915 (comment), I've refactored the add dropdown. Heavily inspired by Drive and Dropbox.

- Separate the `create new folder` from the `add to ipfs` dropdown. This way, everything inside that dropdow is to add file/folder/cid to our repo.
- Renamed the dropdown to just `+ Add`. Previously we had `+ Add to IPFS`, which is not 100% correct. This let me update the `Add by path` which was super confusing, to `Add from IPFS`, which I think is more clear because it tells you you're adding something that is already on IPFS. 

<img width="1279" alt="1" src="https://user-images.githubusercontent.com/33324750/52208434-8be8ff00-2878-11e9-8663-781844a5b1ee.png">

<img width="1279" alt="2" src="https://user-images.githubusercontent.com/33324750/52208435-8d1a2c00-2878-11e9-9732-a42d4fccbf16.png">

Closes #915.
@ghost ghost removed the status/in-progress In progress label Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/discussion Topical discussion; usually not changes to codebase
Projects
None yet
Development

No branches or pull requests

3 participants