Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loading indicator while waiting for files responses #926

Closed
olizilla opened this issue Jan 5, 2019 · 1 comment
Closed

Add loading indicator while waiting for files responses #926

olizilla opened this issue Jan 5, 2019 · 1 comment
Assignees

Comments

@olizilla
Copy link
Member

olizilla commented Jan 5, 2019

If the user copies the root a data-set into their MFS, it is not automatically recursively fetched. (it probably should be)

If a user drills down into a data-set that hasn't yet been fetched, the UI freezes with no information as to what is going on.

A quick test

$ ipfs dns arewedistributedyet.com
/ipfs/QmeANzfbKFunvrenGDVbAttucJvNF6wrWH96QeSWdmgGy6

$ ipfs files cp /ipfs/QmeANzfbKFunvrenGDVbAttucJvNF6wrWH96QeSWdmgGy6 /awdy

Now navigate to the files page in the web ui and click on the /awdy entry. It taks a few seconds to load, while the data is fetched. There is no indication to the user. A larger data set can hang things for minutes.

@olizilla olizilla mentioned this issue Jan 7, 2019
10 tasks
@alx696
Copy link

alx696 commented Jan 16, 2019

@olizilla Better to add progress indicator for add file and download file. Now, It looks like already have one, but not work. The progress info only show when 100%, no tips for a long time. Especially when the file is large.

@fsdiogo fsdiogo self-assigned this Jan 31, 2019
@fsdiogo fsdiogo added the status/in-progress In progress label Jan 31, 2019
fsdiogo added a commit that referenced this issue Feb 6, 2019
Adds a loading animation when changing folders because some requests can hang for a bit and there was no clear indication that something was going on.

When you click on a folder, the files list gets an opacity and I went for something like the youtube cards animation, but keeping the content visible: 

![anim](https://user-images.githubusercontent.com/33324750/52134049-a0d84f00-263a-11e9-9698-f2bbabc69ba4.gif)

Fixes #926.
@ghost ghost removed the status/in-progress In progress label Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants