-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update navbar active item #1022
Conversation
CI is failing and I can't trigger a rebuild (no permissions) 😬 |
@hsanjuan we're seeing the following error when using the ipfs-cluster-ctl to upload site preview in
is that something you've seen before? |
Sorry, the cluster has been offline for about 12 hours due to some raid issues, but it's back up. That said, that error is horrible. we will fix it. |
@olizilla actually we fixed this nil pointer panic already. It's on the 0.10.1 release. |
@fsdiogo awesome! Could the bar be thickened by two pixels or so, in order to stand out a little more clearly? |
@ericronne in the screenshot I posted the bar got a bit cut, can you open the site preview and see if it still needs to be thicker? |
@fsdiogo could you share a preview link? I'm not sure how to find it thx! |
@ericronne scroll to the bottom of the PR and click > "All checks have passed -> show all checks" |
TIL❣️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love.
We should keep a record of all the styles that we use that aren't coming from atoms from ipfs-css or tachyons, so we have a list that we can use to review what should get added to ipfs-css... in the meantime 👍 |
As per #1004.
Update the way a link is active in the navbar: