Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update navbar active item #1022

Merged
merged 1 commit into from
Apr 29, 2019
Merged

Conversation

fsdiogo
Copy link
Contributor

@fsdiogo fsdiogo commented Apr 26, 2019

As per #1004.

Update the way a link is active in the navbar:

nav

@fsdiogo fsdiogo self-assigned this Apr 26, 2019
@ghost ghost added the status/in-progress In progress label Apr 26, 2019
@fsdiogo
Copy link
Contributor Author

fsdiogo commented Apr 26, 2019

CI is failing and I can't trigger a rebuild (no permissions) 😬

@olizilla
Copy link
Member

@hsanjuan we're seeing the following error when using the ipfs-cluster-ctl to upload site preview in

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x9c4c80]

goroutine 70 [running]:
main.main.func6.1(0xc00002b6f4, 0xc0004a0280, 0xc0000b6780)
	github.com/ipfs/ipfs-cluster/cmd/ipfs-cluster-ctl/main.go:436 +0x320
created by main.main.func6
	github.com/ipfs/ipfs-cluster/cmd/ipfs-cluster-ctl/main.go:417 +0x60f
Exited with code 2

is that something you've seen before?

source: https://circleci.com/gh/ipfs-shipyard/ipfs-webui/1688?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

@hsanjuan
Copy link
Contributor

Sorry, the cluster has been offline for about 12 hours due to some raid issues, but it's back up. That said, that error is horrible. we will fix it.

@fsdiogo
Copy link
Contributor Author

fsdiogo commented Apr 26, 2019

Thanks @olizilla and @hsanjuan 👍

@hsanjuan
Copy link
Contributor

@olizilla actually we fixed this nil pointer panic already. It's on the 0.10.1 release.

@ericronne
Copy link

@fsdiogo awesome! Could the bar be thickened by two pixels or so, in order to stand out a little more clearly?

@fsdiogo
Copy link
Contributor Author

fsdiogo commented Apr 26, 2019

@ericronne in the screenshot I posted the bar got a bit cut, can you open the site preview and see if it still needs to be thicker?

@ericronne
Copy link

@fsdiogo could you share a preview link? I'm not sure how to find it thx!

@olizilla
Copy link
Member

@ericronne scroll to the bottom of the PR and click > "All checks have passed -> show all checks"

Screenshot 2019-04-26 at 18 32 11

@ericronne
Copy link

TIL❣️

Copy link

@ericronne ericronne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love.

@olizilla
Copy link
Member

We should keep a record of all the styles that we use that aren't coming from atoms from ipfs-css or tachyons, so we have a list that we can use to review what should get added to ipfs-css... in the meantime 👍

@olizilla olizilla merged commit 11bd558 into master Apr 29, 2019
@ghost ghost removed the status/in-progress In progress label Apr 29, 2019
@olizilla olizilla deleted the chore/update-navbar-active-item branch April 29, 2019 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants