Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow settings even when the daemon is offline #1023

Merged
merged 1 commit into from
Apr 29, 2019

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Apr 28, 2019

This closes #1019 by allowing the Settings page even when IPFS config is not available, or the daemon is offline. It might be useful because the settings page contains much more than IPFS own settings.

Screenshot 2019-04-28 at 09 04 35

License: MIT
Signed-off-by: Henrique Dias hacdias@gmail.com

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@hacdias
Copy link
Member Author

hacdias commented Apr 29, 2019

I know I shouldn't force push, but I did :O Just trying to trigger the CI with the latest updates. For some reason the tests pass locally but weren't passing in the CI.

@olizilla
Copy link
Member

@hacdias you should be able to re-trigger the build via the circle-ci web interface. let me know if that's not the case

@hacdias
Copy link
Member Author

hacdias commented Apr 29, 2019

@olizilla it says I don't have write permissions, which is weird. I believe I could trigger builds before. It passes now though 😄

@olizilla olizilla merged commit c5f3f03 into master Apr 29, 2019
@olizilla olizilla deleted the feat/settings-offline branch April 29, 2019 08:56
@ghost ghost removed the status/in-progress In progress label Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IPFS Desktop, Language and Analytics settings available when the node is offline
2 participants