fix: work even when bandwidth metrics are disabled #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
ghost
assigned License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
hacdias
changed the title
18 tasks
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
olizilla
approved these changes
Apr 29, 2019
public/locales/en/status.json
Outdated
| } | ||
| }, | ||
| "bandwidthStats": "Bandwidth Stats", | ||
| "bandwidthStatsDisabled": "You have the bandwidth metrics disabled. You can enable them by typing the command bellow or changing the key <1>Swarm.DisableBandwidthMetrics</1> to <3>false</3> on <5>Settings</5>." |
There was a problem hiding this comment.
Needs a note about "then restart the IPFS daemon to apply the change."
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1009 and ipfs/ipfs-desktop#893 by showing a message to the user when they have the bandwidth metrics disabled.
Also, removes some duplicated code. We had two bundles doing basically the same thing (fetching bandwidth stats).
License: MIT
Signed-off-by: Henrique Dias hacdias@gmail.com