-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/files progress feedback #1495
Conversation
@rafaelramalho19 This is great, thank you so much! A few thoughts below.
Thanks again! |
6: Do you like this interaction and UI? https://dl.dropboxusercontent.com/s/yzrg6ag7kfz3w3z/6UQusRifgh.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rafaelramalho19 This is awesome! 😊
Three quick requests:
- Could the X/chevron controls in the top right please be nudged to the right slightly, so the visual margin is equal on top, bottom, and right?
- Let's keep the files just the generic file icon for now (not worth the work in differentiating file types, as you noted), but please use the "no word lines" file icon:
- The folder icon isn't quite the same as the one from the main files view. Could it please be the same one? (Hopefully this isn't an ipfs-css inconsistency problem ...)
Thank you!
Awesome, thanks! |
1 similar comment
Awesome, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nits:
If user selects some files right after importing them, "selection info bar" slides from the bottom and things look a bit awkward:
-
the X button has different shade -- I think we should use the lighter color everywhere
-
would be cool if "progress feedback" moved above the info bar,
but if its too much work i think an easy fix would be to tweak z-index and bring the "progress bar" behind "selection bar" (caveat: make sure to not hide error popups in the process – see below)
Another thing, when importing a directory with a name that is already present, I get this error message, which surfaces some icon extravaganza we need to tame :-)
I think we should cleanup icons:
- use "X" (just character, no circle) for closing (including the orange error box)
- use "(X)" only for failed operation
@lidel does this cover all your suggestions? Moving the progress bar to the top of the selection info is possible, but it involves adding calculations of the offsetHeight + adding event listeners for resizing, and that decreases performance. But if you and @jessicaschilling think that it's worth it, I'll do it 😄 |
I’m not terribly bothered by the positioning of the progress bar, since it’s indefinite progress right now. Might want to revisit once we have the opportunity for actual progress? But I’ll defer to @lidel. |
a5f5022
to
493f0ab
Compare
Resolves #1206
UI context information: https://www.figma.com/file/BQjzJcaKuNrNgeDnoZ664D/Web-UI-upload%2Fdownload-progress?node-id=0%3A1
Here's a video showing the current status:
https://dl.dropboxusercontent.com/s/a94hwolhhtjb8bn/TQQGFkhNpF.mp4
Questions