Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Improve style setup #152

Merged
merged 2 commits into from
Jan 1, 2016
Merged

refactor: Improve style setup #152

merged 2 commits into from
Jan 1, 2016

Conversation

dignifiedquire
Copy link
Member

No description provided.

This will allow for easier modification and styling of
bootstrap variables
@jbenet jbenet added the status/in-progress In progress label Jan 1, 2016
@dignifiedquire dignifiedquire added codereview and removed status/in-progress In progress labels Jan 1, 2016
@import "../../node_modules/bootstrap/less/pager";
@import "../../node_modules/bootstrap/less/labels";
@import "../../node_modules/bootstrap/less/badges";
@import "../../node_modules/bootstrap/less/jumbotron";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need jumbotron and all the others here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a 1:1 copy of the requires from bootstrap itself, I have not removed any unused code yet.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to #153

@daviddias
Copy link
Member

overall LGTM :)

dignifiedquire added a commit that referenced this pull request Jan 1, 2016
refactor: Improve style setup
@dignifiedquire dignifiedquire merged commit 485a978 into master Jan 1, 2016
@dignifiedquire dignifiedquire deleted the styles branch January 1, 2016 22:08
@jbenet jbenet removed the codereview label Jan 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants