Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 1937 -Not able to use private network gateway due to 1x1.png #1944

Merged
merged 3 commits into from
Jul 11, 2022

Conversation

ymlai87416
Copy link
Contributor

fix #1937 issue by adopting @lidel suggestion.

@welcome
Copy link

welcome bot commented Jun 9, 2022

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@lidel lidel force-pushed the main branch 4 times, most recently from dabaee3 to 7ddf870 Compare June 29, 2022 22:19
src/bundles/gateway.js Show resolved Hide resolved
src/bundles/gateway.js Outdated Show resolved Hide resolved
src/bundles/gateway.js Outdated Show resolved Hide resolved
@SgtPooki
Copy link
Member

SgtPooki commented Jul 9, 2022

Thanks so much for this PR, just a few minor fixes

@SgtPooki SgtPooki added need/author-input Needs input from the original author status/in-progress In progress status/ready Ready to be worked and removed need/author-input Needs input from the original author labels Jul 9, 2022
@ipfs-gui-bot
Copy link
Collaborator

🎉 This PR is included in version 2.18.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not able to use private network gateway due to 1x1.png
3 participants