fix: resolve issues with automated releases #1974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SgtPooki
force-pushed
the
feat/attach-car-with-semantic-release
branch
from
f495c4d
to
1b4b31d
Compare
|
@achingbrain I was told by @BigLep that you've got a release setup where a PR is opened, and then added to as commits are merged into the main branch, and then you kick of a release just by merging that "release" PR. Is that correct? If so, I would love to get that set up here. Can you point me in the right direction? |
SgtPooki
force-pushed
the
feat/attach-car-with-semantic-release
branch
from
1b4b31d
to
6d3e1e6
Compare
|
@SgtPooki - yes, libp2p and ipfs both use gated releases via release-please which it sounds like you are after - here's some example config - let me know if anything doesn't make sense. |
SgtPooki
added
P0
hacdias
approved these changes
Jul 19, 2022
lidel
added a commit
that referenced
this pull request
Aug 9, 2022
* docs(readme): update translations release steps * docs(readme): Releases are 99% automated * docs: manual release dispatch Manual mode introduced in #1974 Co-authored-by: Marcin Rataj <lidel@lidel.org>
ipfs-gui-bot
pushed a commit
that referenced
this pull request
Sep 9, 2022
## [2.18.0](v2.17.3...v2.18.0) (2022-09-09) CID `bafybeidb5eryh72zajiokdggzo7yct2d6hhcflncji5im2y5w26uuygdsm` --- ### Features * IPNS Publishing ([#1973](#1973)) ([4ff4939](4ff4939)) * ux improvements to publish modal ([#1998](#1998)) ([ea4f632](ea4f632)) ### Bug Fixes * **ci:** parsing "ipfs-cluster-ctl peers ls" output ([#1966](#1966)) ([828e460](828e460)) * korean detection ([#2005](#2005)) ([362dab8](362dab8)) * Kubo agent text to link via ReleaseLink [#2010](#2010) ([#2011](#2011)) ([3d04988](3d04988)) * nodejs readme badges ([#1985](#1985)) ([a9e661b](a9e661b)) * remove web ui version and keep revision ([#2000](#2000)) ([42ed78d](42ed78d)) * resolve issues with automated releases ([#1974](#1974)) ([9a7cfad](9a7cfad)) ### Trivial Changes * add missing classnames dependency ([#1977](#1977)) ([c4216b8](c4216b8)) * **deps:** update react-scripts ([#1969](#1969)) ([136b260](136b260)) * pull transifex translations ([#1996](#1996)) ([0de4267](0de4267)) * Pull transifex translations ([#2003](#2003)) ([cc51b15](cc51b15)) * **readme:** NodeJS version support info ([#1986](#1986)) ([829450d](829450d)) * **readme:** update release steps ([#1963](#1963)) ([c5b4822](c5b4822)) * Update .github/workflows/stale.yml [skip ci] ([f15818d](f15818d)) * update storybook and stories ([#2007](#2007)) ([83ceac1](83ceac1)), closes [/github.com/storybookjs/storybook/blob/next/MIGRATION.md#webpack-5](https://github.com/ipfs//github.com/storybookjs/storybook/blob/next/MIGRATION.md/issues/webpack-5)
|
🎉 This PR is included in version 2.18.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After enabling automated releases for this repo, I noticed a number of issues:
workflow_dispatch). This is still a significant improvement upon the previous manual process"files":in the package.json allows us to limit which files are included.ci.ymlworkflow, so everything in the ci.yml workflow could go great, and then fail during semantic-release job.Also, see #1970
This PR attempts to resolve all of the above issues.