Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #31, allowing unpinning via the webui #35

Merged
merged 1 commit into from
Apr 27, 2015
Merged

Conversation

travisperson
Copy link
Member

There are few fixes in this, mostly though this is to allow users to
unpin from the webui. This commit includes a version bump of the
node-ipfs-api, as well as passing in the recursive flag.

An unexpected addition to this commit is due to a change in go-ipfs
passing back an object of keys instead of an array.

There are few fixes in this, mostly though this is to allow users to
unpin from the webui. This commit includes a version bump of the
`node-ipfs-api`, as well as passing in the recursive flag.

An unexpected addition to this commit is due to a change in `go-ipfs`
passing back an object of keys instead of an array.
@jbenet jbenet added the status/in-progress In progress label Apr 27, 2015
@travisperson
Copy link
Member Author

See ipfs/kubo@0a6b880 for change to js/pages/files.jsx

@jbenet
Copy link
Member

jbenet commented Apr 27, 2015

@travisperson would love to be able to have some testing on these commits. they look good to me, but we dont have automated testing :(

jbenet added a commit that referenced this pull request Apr 27, 2015
Fixes #31, allowing unpinning via the webui
@jbenet jbenet merged commit f3fccf9 into master Apr 27, 2015
@jbenet jbenet removed the status/in-progress In progress label Apr 27, 2015
@jbenet jbenet deleted the bug/recursive-pin branch April 27, 2015 07:27
@travisperson
Copy link
Member Author

Definitely, that is something we should focus on in the next sprint, would love to get @STRML in on the discussion as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants