Remove polling interval from files view #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Im totally on board with 100% CPU -> idle. 👍 |
|
Yeah let's do it — On Sat, May 16, 2015 at 2:07 PM, Jeromy Johnson notifications@github.com
|
jbenet
added a commit
that referenced
this pull request
May 16, 2015
Remove polling interval from files view
This was referenced Apr 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This made the files page go from eating 100% cpu to idle.
I'd argue the relevant time you want to update these listings, is while adding files through the webui, and as this case is already covered without polling, i think we should just drop this line.
Cannot think of any usecase where you would want to have polling updates of pinned files at this point.
Maybe it does not fix #20 in its entirety, but it makes a huge difference in performance.