feat: guide the user when no api found #715

olizilla · 2018-07-06T16:28:25Z

Inform the user when we can't connect to the API and give them the option to set a custom api address.

Early WIP on #711

License: MIT
Signed-off-by: Oli Evans oli@tableflip.io

hacdias · 2018-08-03T12:40:54Z

Requires:

feat: more selectors ipfs-inactive/ipfs-redux-bundle#1

hacdias · 2018-08-03T13:05:31Z

@olizilla I've made some changes. Please take a look to ipfs-redux-bundle.

If we can't connect to an instance, it redirects to /welcome.
It won't let you open any other page if there isn't a valid IPFS instance.
- This makes our navigation tests fail on CI because there isn't an IPFS instance running. Suggestions? We could start a js-ipfs instance so it connects and does everything else.
Cache! So, you set an API address, reload the page, and it's still the same address.
You can always go to /welcome and change the API url.

License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

olizilla

Redirecting the url when ipfsReady is false feels like something that we should set up in redux.

We should catch the condition that the welcome page bundle has loaded, but IPFS isn't ready and there is no error. It can just show a loading spinner on the welcome in that case.

hacdias · 2018-08-21T08:28:46Z

@olizilla

Redirecting the url when ipfsReady is false feels like something that we should set up in redux.

It is on redirects bundle.

We should catch the condition that the welcome page bundle has loaded, but IPFS isn't ready and there is no error. It can just show a loading spinner on the welcome in that case.

Done.

When failed to connect.

After being successfully connected

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

hacdias · 2018-08-21T10:21:12Z

@olizilla btw changed 'Your IPFS is running!' to 'Your IPFS daemon is running!'

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

olizilla · 2018-08-21T10:39:38Z

@hacdias To complete this challenge please appease the CI gods. The tests should pass and the test coverage should not go down. Of note the navigation test that is failing was really a place holder for more exciting e2e tests. Do you accept this mission?

hacdias · 2018-08-21T10:44:01Z

For this PR I can add tests with and without a node running. We can then think about more tests haha. Sounds good @olizilla?

olizilla · 2018-08-21T10:45:19Z

@hacdias 💯

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

hacdias · 2018-08-21T11:20:51Z

@olizilla could you take a look at the code? I'm getting Protocol error (Runtime.callFunctionOn): Target closed.. I found some solutions online related to the memory, but they don't seem to work. I've also tried connecting with the Address instead of setting window.ipfs but the error persists.

olizilla · 2018-08-21T15:03:51Z

test/e2e/navigation.test.js

  // Save 3s per run by using the initial page rather than creating a new one!
  // const page = await browser.newPage()
  const page = (await browser.pages())[0]

+  await page.evaluate(() => {
+    window.ipfs = node


@hacdias ok so, this is a rad idea, but I don't think it'll work. With the e2e tests things get complicated, as the test is running in jest in node, and firing up a browser instance with it's own seperate runtime. I don't think we'll ever be able to create an ipfs instance in a node runtime and smoosh it into a browser without very weird things happening.

Much more minor, the api for page.evaluate requires you to pass any args you want to hand to the page, and they get magically transferred as args to the callback function when it is executed in the context of the page instance. Even so, like going through a black hole, an ipfs instance won't survive the trip.

One solution is to create a fake window.ipfs object with an id function that resolves with a test identity info, and then check for that. We don't need to test that js-ipfs works in the webui tests, so it's ok to stub it out.

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

hacdias · 2018-08-21T21:54:42Z

@olizilla made some updates and mocking but it seems to fail here: 6a0f41d#diff-0238dfb49a06ba796757bff9fcff0faaR41

There might be something on the files page that blocks the rendering? I can't see what it might be though. I tried adding empty functions for files.ls and files.stat but it didn't work.

olizilla · 2018-08-24T09:03:20Z

@hacdias i'll take a look at this now

hacdias · 2018-08-24T09:12:51Z

Thank you @olizilla

License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>

remove selectApiUrl from config bundle as it's better got from the ipfs bundle License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>

License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>

…found

olizilla added the status/in-progress In progress label Jul 6, 2018

hacdias added the revamp label Jul 11, 2018

hacdias mentioned this pull request Jul 23, 2018

UI thinks my daemon isn't running #737

Closed

hacdias force-pushed the feat/revamp/no-api-found branch from 89ba3a1 to e04f367 Compare August 3, 2018 09:23

hacdias force-pushed the feat/revamp/no-api-found branch 2 times, most recently from 18f18b9 to de276b3 Compare August 4, 2018 09:52

olizilla mentioned this pull request Aug 16, 2018

v2.0.0 Release 🚢 Shipping the Revamp 🚀 #749

Closed

15 tasks

olizilla and others added 11 commits August 20, 2018 09:42

wip: guide the user when no api found

f6417f2

License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>

fix: lint and build warnings

644d1c3

License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>

Updates the apiAddress successfully

426153f

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

fix config bundle and welcome page is working

641ef72

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

use regular quotes

9a785a5

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

cache friendly

788478d

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

use ipfs-redux-bundle

2cf4f44

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

add cache

644e263

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

fix app test

9199d4e

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

loadable welcome page

44458f9

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

use newest ipfs-redux-bundle

fc80b8b

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

hacdias force-pushed the feat/revamp/no-api-found branch from de276b3 to fc80b8b Compare August 20, 2018 08:54

olizilla commented Aug 20, 2018

View reviewed changes

feat: load component while not connected

a7e14b5

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

hacdias force-pushed the feat/revamp/no-api-found branch from a370173 to a7e14b5 Compare August 21, 2018 08:56

fix typo and add 'daemon' word

cfe20d8

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

update redux bundle

55af5bf

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

hacdias changed the title ~~[wip] guide the user when no api found~~ feat: guide the user when no api found Aug 21, 2018

run node on tests

41dc89b

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

olizilla commented Aug 21, 2018

View reviewed changes

improve tests

6a0f41d

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

olizilla added 4 commits August 24, 2018 10:55

fix: mock ipfs in quick e2e test

c40f793

License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>

fix: dont redirect to welcome if already there

71d1f79

remove selectApiUrl from config bundle as it's better got from the ipfs bundle License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>

fix: tweak copy on the welcome page

2acf148

License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>

Merge remote-tracking branch 'origin/revamp' into feat/revamp/no-api-…

ca0707e

…found

olizilla merged commit 7a1c0f1 into revamp Aug 24, 2018

olizilla deleted the feat/revamp/no-api-found branch August 24, 2018 11:20

lidel mentioned this pull request Sep 6, 2018

feat: add welcome page ipfs/ipfs-companion#565

Merged

olizilla mentioned this pull request Sep 27, 2018

IPFS node selector #711

Closed

snyk-bot mentioned this pull request Jun 1, 2021

[Snyk] Upgrade @loadable/component from 5.14.1 to 5.15.0 Jsn2win/ipfs-webui#11

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: guide the user when no api found #715

feat: guide the user when no api found #715

olizilla commented Jul 6, 2018

hacdias commented Aug 3, 2018 •

edited

Loading

hacdias commented Aug 3, 2018

olizilla left a comment

hacdias commented Aug 21, 2018 •

edited

Loading

hacdias commented Aug 21, 2018

olizilla commented Aug 21, 2018

hacdias commented Aug 21, 2018

olizilla commented Aug 21, 2018

hacdias commented Aug 21, 2018

olizilla Aug 21, 2018

hacdias commented Aug 21, 2018

olizilla commented Aug 24, 2018

hacdias commented Aug 24, 2018

feat: guide the user when no api found #715

feat: guide the user when no api found #715

Conversation

olizilla commented Jul 6, 2018

hacdias commented Aug 3, 2018 • edited Loading

hacdias commented Aug 3, 2018

olizilla left a comment

Choose a reason for hiding this comment

hacdias commented Aug 21, 2018 • edited Loading

When failed to connect.

After being successfully connected

hacdias commented Aug 21, 2018

olizilla commented Aug 21, 2018

hacdias commented Aug 21, 2018

olizilla commented Aug 21, 2018

hacdias commented Aug 21, 2018

olizilla Aug 21, 2018

Choose a reason for hiding this comment

hacdias commented Aug 21, 2018

olizilla commented Aug 24, 2018

hacdias commented Aug 24, 2018

hacdias commented Aug 3, 2018 •

edited

Loading

hacdias commented Aug 21, 2018 •

edited

Loading