Modularized webui #73
Conversation
|
Ok, i got a mega-conflict here since master changed by one commit while i was reorganizing everything. I could manually incorperate the patch, but i think a rebase will simply not be possible here. Any git advice here? |
|
Manual is fine, just flag the previous commit so we can make sure it's the same in CR :) |
|
(Same/similar) |
| ## Dev | ||
|
|
||
| ```bash | ||
| git clone https://github.com/ipfs/webui | ||
| cd ipfs-webui | ||
| npm install | ||
| # Runs server on port 8000. Set env PORT to change. | ||
| ./alldeps.sh |
There was a problem hiding this comment.
why remove the makefile? makefile can do this easier. + can have other targets, like publish.
|
should probably use webcomponents, as we discussed with @diasdavid, but will CR some anyway. @diasdavid, would be great to get your input here too |
| React.render(<Connections ipfs={ipfs} />, | ||
| document.getElementById('mount')) | ||
| } | ||
| }) |
There was a problem hiding this comment.
if we could match the typical
module.exports = function() {
}
// or
module.exports = {} type of thing, that may be nice. maybe not easy? this may be ok. impressions @diasdavid?
There was a problem hiding this comment.
I typically see (and do) code like
// If the module has a constructor
exports = module.exports [= <name of func that might be a constructor or main call of this module>]
// and then, for other calls:
exports.anotherThing = function () { }
If the module is a facade, I do exports.<something> for all of them instead of doing module.exports = {}
This way, if you can declare exported values along the file and you don't have to update the exported interface in two places.
|
hard to tell everything that changed becuase the github diff is off and the PR is huge. maybe splitting off the apps into own repos will help scope the CR 👍 |
|
@krl in general like where this is at. if it all works well, that's very nice already! 👍 |
|
@krl any luck with the webcomponetized webui? It would be cool to get that also with #75 to go-ipfs, so that ipfs/ipfs-desktop#23 gets fixed //cc @whyrusleeping |
|
yeah status here? |
|
Whats the status here @krl ? ETA to be finished? There are some people looking to help on the webui and it would be awesome if they can contribute on the new Web Componentized version |
|
@diasdavid hey, sorry for being out of the loop for a bit, i'm going to have a look at this again next week |
|
@krl nice :) If you have the times to also describe the goal of 'Web Componetizing' all of the things, could be good for people doing work on the other IPFS apps to follow the model. @giodamelio wants to contribute to the webui :) |
|
we should come up with a simple plan to webcomponentize all the things, and
merge this, etc. other people want to help here and maybe we can divide up
the work.
@krl maybe the first next step is to outline the rest of the necessary
steps.
|
|
Also it would be good to have an outline about the tooling especially in relation to react, as from |
|
@krl updates on this PR? I eager and excited for the moment we can write tests for the webui |
|
After the latest discussions I will close this (see notes here: ipfs/team-mgmt#55 (comment)) Will create issues with detailed todos in the next days, but the gist is that we will use react components for the webui with a simple build process rather than trying to get webcomponents and react married. Thanks @krl for all the work and discussions! |
Major rehaul of the webui architecture.
Logs and Config are not in yet.
Config is blocked on making ipfs.add solid in the browser, and logs on changing back the log entry point into the api.