Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: analytics opt-in per type #985

Merged
merged 9 commits into from
Mar 13, 2019
Merged

feat: analytics opt-in per type #985

merged 9 commits into from
Mar 13, 2019

Commits on Mar 6, 2019

  1. wip: analytics tweaks based on feedback 

    see: #980

License: MIT
Signed-off-by: Oli Evans <oli@tableflip.io>
    @olizilla
    olizilla committed Mar 6, 2019
    Configuration menu
    Copy the full SHA
    3375804 View commit details
    Browse the repository at this point in the history

  2. wip: remove debug logging 

    License: MIT
Signed-off-by: Oli Evans <oli@tableflip.io>
    @olizilla
    olizilla committed Mar 6, 2019
    Configuration menu
    Copy the full SHA
    9ff5f41 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2019

  1. wip: improve copy and error reporting 

    License: MIT
Signed-off-by: Oli Evans <oli@tableflip.io>
    @olizilla
    olizilla committed Mar 8, 2019
    Configuration menu
    Copy the full SHA
    30a077e View commit details
    Browse the repository at this point in the history

  2. wip: improve copy and view source links 

    License: MIT
Signed-off-by: Oli Evans <oli@tableflip.io>
    @olizilla
    olizilla committed Mar 8, 2019
    Configuration menu
    Copy the full SHA
    0c2bac9 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2019

  1. feat: enable analytics consent per type 

    You can now opt-in to:
- Sessions and browser metrics
- Events
- Page views
- Location
- App errors

Toggle at the top level enables all but app errors, as they could
contain CIDs or file paths, so must be enabled seperately.

License: MIT
Signed-off-by: Oli Evans <oli@tableflip.io>
    @olizilla
    olizilla committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    3bbb145 View commit details
    Browse the repository at this point in the history

  2. fix: add tests for toggle consent 

    License: MIT
Signed-off-by: Oli Evans <oli@tableflip.io>
    @olizilla
    olizilla committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    64c01e0 View commit details
    Browse the repository at this point in the history

  3. chore: init with mock countly instance 

    Countly will set itself on the window object, so no need to do so manually.
Ensure a mock Countly prop exists, so code that expects it later on doesnt
explode if it hasn't loaded.

License: MIT
Signed-off-by: Oli Evans <oli@tableflip.io>
    @olizilla
    olizilla committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    d008335 View commit details
    Browse the repository at this point in the history

  4. show ask to enable on status page. 

    adds a "more info" link to the status page ask, that takes the user
to a stripped down settings page with just the analytics toggle
already expanded, to focus things on the current task.

License: MIT
Signed-off-by: Oli Evans <oli@tableflip.io>
    @olizilla
    olizilla committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    2fb9df4 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2019

  1. tweak layout based on feedback 

    License: MIT
Signed-off-by: Oli Evans <oli@tableflip.io>
    @olizilla
    olizilla committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    424373c View commit details
    Browse the repository at this point in the history