feat!: remove all old deps #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
url is localhost:port/#/explore/bafybeiaysi4s6lnjev27ln5icwm6tueaw2vdykrtjkwiphwekaywqhcjze based on latest hash from https://github.com/ipfs/distributed-wikipedia-mirror/blob/1aa50702fc6d8e2be106e37d4c68dc2ca5b94f20/snapshot-hashes.yml#LL13C10-L13C69
This reverts commit ca0a50b.
2 tasks
3 tasks
whizzzkid
reviewed
Jun 7, 2023
| import 'react-virtualized/styles.css' | ||
| import { composeBundles, createRouteBundle } from 'redux-bundler' | ||
| import { Provider as ReduxStoreProvider, connect } from 'redux-bundler-react' | ||
| import 'tachyons' |
There was a problem hiding this comment.
can we sort/organize imports across?
There was a problem hiding this comment.
i'm not sure what that means. see .eslintrc.js 'import/order'.groups
| error: null | ||
| } | ||
|
|
||
| function getUserOpts (key: string): Record<string, unknown> { |
There was a problem hiding this comment.
Cause it can be anything.. it's localStorage
| <div> | ||
| <div className='f5 sans-serif fw5 ma0 pv2 truncate navy'> | ||
| {cid} | ||
| </div> | ||
| <div className='red fw2 ma0 f7'>{cidErr.message}</div> | ||
| </div> | ||
| )} | ||
| )} |
There was a problem hiding this comment.
it's using standard style for formatting, so it should be correct. build runs lint which runs standard, so it would fail if it werent correct.
There was a problem hiding this comment.
this is already a pretty large change, I'm trying not to modify any of the horrendous jsx or ternary statements that already existed before I got here. we can do a pass later
whizzzkid
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When will this PR be removed from Draft/WIP?
bafyreicnokmhmrnlp2wjhyk2haep4tqxiptwfrp2rrs7rzq7uk766chqvq/cheese/0path, currently showingError: Requested IPLD path should end with the remainder patherrorThis PR was mainly intended to address #359, but in the process, we were able to solve a number of longstanding issues.
Preview of these changes in explore.ipld.io are available at https://bafybeici5vqsnnrggriwslm5m6ztoyedcumk2imy62ywwjficn5qt6fw6u.on.fleek.co/
This PR has the following changes:
src/lib/get-raw-block.ts(seeipld-explorer-components/src/lib/get-raw-block.ts
Line 105 in 75461c2
fixes #359
fixes #279
fixes #311
fixes #335
fixes #355
This is a large win for work required from ipfs/ipfs-webui#1965
related to explore.ipld.io changes at ipld/explore.ipld.io#119
Demo Video:
explore.ipld.io-2023-05-25-update.mp4