Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: explore page can query local kubo #445

Merged
merged 2 commits into from
Sep 23, 2024
Merged

fix: explore page can query local kubo #445

merged 2 commits into from
Sep 23, 2024

Conversation

SgtPooki
Copy link
Member

  • chore: explainer comments
  • fix: allowInsecure isn't needed for local gateways

@SgtPooki SgtPooki requested a review from a team as a code owner September 23, 2024 21:26
Copy link
Member Author

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self review

@@ -163,7 +163,7 @@
"test:storybook:ci": "concurrently -k -s first -n \"SB,TEST\" -c \"magenta,blue\" \"storybook build --quiet && http-server storybook-static --port 6006 --silent\" \"wait-on 'tcp:127.0.0.1:6006' && test-storybook --coverage\""
},
"dependencies": {
"@helia/block-brokers": "^3.0.3",
"@helia/block-brokers": "^3.0.4",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addresses ipfs/ipfs-webui#2268 (comment)

even though this is a patch update, I think since we have a package-lock.json, webui isn't getting the fix automatically.

@@ -76,7 +76,7 @@ const bundle = {

try {
console.info(
"🎛️ Customise your Kubo gateway opts by setting an `kuboGateway` value in localStorage. e.g. localStorage.setItem('kuboGateway', JSON.stringify({port: '1337'}))"
"🎛️ Customise your Kubo gateway opts by setting a `kuboGateway` value in localStorage. e.g. localStorage.setItem('kuboGateway', JSON.stringify({ port: '8080', trustlessBlockBrokerConfig: { init: { allowLocal: true, allowInsecure: true }}}))"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more helpful example in browser console

@SgtPooki SgtPooki merged commit d06b15b into master Sep 23, 2024
16 checks passed
@SgtPooki SgtPooki deleted the fix/webui branch September 23, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant