This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
Refactor datastore core to use async/await instead of callbacks #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkmc
suggested changes
Mar 13, 2019
There was a problem hiding this comment.
Nice work @zcstarr, the code is so much nicer with async/await 👍
I made a couple of small suggestions in the code but overall looks really good. In general I would suggest
- using streaming-iterables functions instead of rolling our own
- I don't think you need to explicitly mark a function as
asyncif it already returns a Promise - In some places you can use err-code so that you can then refer to that code explicitly in the tests (see eg https://github.com/libp2p/js-libp2p-kad-dht/blob/master/test/kad-dht.spec.js#L403)
| async open () /* : void */ { | ||
| try { | ||
| await (this.stores.map((store) => store.open())) | ||
| } catch (err) { |
There was a problem hiding this comment.
I know this wasn't part of the original code, but I wonder if we should log the error here?
| cb() | ||
| }) | ||
| }, callback) | ||
| async has (key /* : Key */) /* : Promise<bool> */ { |
There was a problem hiding this comment.
Would it make sense to do this in parallel? It's a little tricky because you want to return true as soon as you get a true response from a store, but it should be possible with a function from streaming-iterables (maybe transform()?)
| each(batches, (b, cb) => { | ||
| b.commit(cb) | ||
| }, callback) | ||
| commit: async () /* : Promise<void> */ => { |
| @@ -0,0 +1,9 @@ | |||
| 'use strict' | |||
There was a problem hiding this comment.
You can use streaming-iterables collect()
2 tasks
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored the package to use async/await as per ipfs/js-ipfs#1670. I added a helper function many that might make sense to move into datastore-interface util, if its generally useful to round robin async iterables. Let me know what you think, happy to jump in and patch up, any feedback greatly appreciated!