Windows #4
Windows #4
Conversation
…me always uses '/'
Using the node-glob package to find files. Its currently synchronous!
|
Waiting on ipfs/interface-datastore#12 and ipfs/js-datastore-core#3 to be released. |
| @@ -5,7 +5,7 @@ | |||
| "main": "src/index.js", | |||
| "scripts": { | |||
| "lint": "aegir-lint", | |||
| "test": "aegir-test --env node", | |||
| "test": "aegir-test --env node --timeout 20000", | |||
There was a problem hiding this comment.
Why do we need this now? Have timeouts increased with this changes? If so, we should have individual timeouts.
There was a problem hiding this comment.
Yes a lot of tests were skipped. In particular the many (3 * 400) test takes a long time on my top-end laptop when sharding.
package.json
Outdated
| @@ -55,6 +55,7 @@ | |||
| }, | |||
| "contributors": [ | |||
| "David Dias <daviddias.p@gmail.com>", | |||
| "Friedel Ziegelmayer <dignifiedquire@gmail.com>" | |||
| "Friedel Ziegelmayer <dignifiedquire@gmail.com>", | |||
| "Richard Schneider <makaretu@gmail.com>" | |||
There was a problem hiding this comment.
this is not needed, its added automatically on release.
There was a problem hiding this comment.
ok will reset
| let pattern = | ||
| path.join(this.path, prefix, '*' + this.opts.extension) | ||
| .split(path.sep) | ||
| .join('/') |
There was a problem hiding this comment.
shouldn't this be the inverse? Split by the key separator / and the join with the os specific path sep?
There was a problem hiding this comment.
Beg to differ. The path.join creates an os specific path. The split(path.sep) then gives an array from the os specific ath and then join('/') creates a POSIX specific path, which is what glob wants,
There was a problem hiding this comment.
ah glob.sync does expect POSIX / separators - makes sense 👍
|
yeah, flow will enable some stricter type checking - looking at travis now. |
|
Why is |
|
@richardschneider I believe this might help - #5. Could you try those changes in your branch? |
|
@richardschneider you also need those |
|
@dignifiedquire do we still want to use flow? I haven't seen it used anywhere else in the codebase and it might not worth the effort to support it at this point. I'm not sure why it broke now though, that's a good question. |
|
Yes, unless there is a strong reason to remove it I believe it is good to keep it as it makes sure that the |
Get it working on windows.
Note that I replaced the package
pull-globwithglob; because it does work on windows.This PR is dependent on ipfs/interface-datastore#12 getting released.