Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

fix: add test data to IPFS before fetching it #832

Merged
merged 1 commit into from
Aug 14, 2018

Conversation

achingbrain
Copy link
Collaborator

See #806 (comment) for context.

@achingbrain
Copy link
Collaborator Author

Hmm, our tests really shouldn't be going to the network, so unreliable:

  1) .util .urlAdd http:
     Uncaught AssertionError: expected [Error: connect ETIMEDOUT 93.184.216.34:80] to not exist
      at ClientRequest.ipfs.util.addFromURL (test\util.spec.js:120:28)
      at Socket.socketErrorListener (_http_client.js:382:9)
      at emitErrorNT (internal/streams/destroy.js:82:8)
      at emitErrorAndCloseNT (internal/streams/destroy.js:50:3)
      at process._tickCallback (internal/process/next_tick.js:63:19)

  2) .util .urlAdd https:
     Uncaught AssertionError: expected [Error: connect ETIMEDOUT 93.184.216.34:443] to not exist
      at ClientRequest.ipfs.util.addFromURL (test\util.spec.js:130:28)
      at TLSSocket.socketErrorListener (_http_client.js:382:9)
      at emitErrorNT (internal/streams/destroy.js:82:8)
      at emitErrorAndCloseNT (internal/streams/destroy.js:50:3)
      at process._tickCallback (internal/process/next_tick.js:63:19)

@alanshaw
Copy link
Contributor

Agree - #803

@alanshaw
Copy link
Contributor

Merging this anyway - test failures are because of reliance on external services. Issue tracked here #803.

@alanshaw alanshaw merged commit b2a77d6 into master Aug 14, 2018
@alanshaw alanshaw deleted the add-data-to-ipfs-before-fetching branch August 14, 2018 12:05
@ghost ghost removed the in progress label Aug 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants