chore: replace protons with protobufjs #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces protons with the official protobufjs module.
achingbrain
commented
Apr 14, 2021
| wantType: Message.Wantlist.WantType.Block | ||
| }) | ||
| const deserialized = await BitswapMessage.deserialize(serialized) | ||
| expect(deserialized.wantlist.get(cid.toString())).to.have.nested.property('entry.wantType', Message.Wantlist.WantType.Block) |
There was a problem hiding this comment.
Protons did some non-standard things here - sendDontHave and wantType should come back as undefined but instead came back as false and 0 respectively in line with the comment in the .proto definition.
Protobufjs follows the spec and does not do this so we can't test against the output of the protobuf deserializer but neither should we, really as it's not the unit under test.
There was a problem hiding this comment.
protons was a mess, happy that we are getting rid of it
vasco-santos
approved these changes
Apr 14, 2021
|
Three bytes!
|
Co-authored-by: Vasco Santos <vasco.santos@moxy.studio>
77 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces protons with the official protobufjs module.