Skip to content
This repository has been archived by the owner on Aug 11, 2021. It is now read-only.

Streams VS Callbacks API #13

Closed
daviddias opened this issue Apr 24, 2016 · 0 comments · Fixed by #14
Closed

Streams VS Callbacks API #13

daviddias opened this issue Apr 24, 2016 · 0 comments · Fixed by #14

Comments

@daviddias
Copy link
Member

In order to avoid the racing condition that became 100% obvious with the addition of locks to ipfs-repo(which made it slower and therefore creating a race condition 100% of the times), I've added a setTimeout to our callbacks API, making sure the callback is postponed till the write happens. This is not the correct solution, because if we try to do a heavy number of parallel writes, it won't save us.

Line: https://github.com/ipfs/js-ipfs-blocks/pull/12/files#r60848208

I want to move it to polling to make sure it was written. @dignifiedquire could you confirm this is the only viable option, with all your work on the same issue on idb-plus-blob-store.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant