Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library cannot be used in a browser environment #5

Closed
bgrieder opened this issue Apr 2, 2016 · 2 comments
Closed

Library cannot be used in a browser environment #5

bgrieder opened this issue Apr 2, 2016 · 2 comments

Comments

@bgrieder
Copy link

bgrieder commented Apr 2, 2016

This is in reference to ipfs/js-ipfs#104

The lib reads the protobuf schema from the FS which prevents from using it in a browser environment

const protobuf = require('protocol-buffers')
const schema = fs.readFileSync(path.resolve(__dirname, 'unixfs.proto'))

This prevents adding a Buffer from the browser into the Merkle DAG

@bgrieder
Copy link
Author

bgrieder commented Apr 2, 2016

Should we use this ? https://github.com/brianchirls/proto-loader

@daviddias
Copy link
Member

I've updated and released 0.1.2. Tests work in Node.js and in the browser and it makes the module available using the new pipeline. Let me know if you still have problems

@nginnever let's update js-ipfs and js-ipfs-data-importing to use the latest of js-ipfs-unixfs :)

@bgrieder bgrieder closed this as completed Apr 4, 2016
achingbrain pushed a commit that referenced this issue Feb 19, 2020
WIP: fix nested dirs bug
achingbrain added a commit that referenced this issue Feb 19, 2020
fix: export all files from hamt sharded directories
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants