feat: support iterators and async iterators #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to accept async interators as arguments to `ipfs.add` and friends. It also allows adding plain old js things like strings and arrays, so hooray for that.
|
PR from my own fork 'cos I don't have push access to this repo. |
3 tasks
alanshaw
requested changes
Aug 23, 2019
| @@ -14,6 +14,8 @@ const expect = chai.expect | |||
|
|
|||
| describe('add-input-validation', function () { | |||
| it('validates correct primitive input types', function () { | |||
| expect(validate('Hello world')).to.be.true() | |||
| expect(validate([0, 1, 2, 3])).to.be.true() | |||
alanshaw
approved these changes
Aug 28, 2019
|
@achingbrain there are some lint warnings causing this to fail in CI |
|
Should be all good now. |
Closed
hugomrdias
suggested changes
Aug 30, 2019
There was a problem hiding this comment.
@achingbrain what you wanna do about pull-streams ? should it be removed too ?
| @@ -24,7 +22,7 @@ const validateAddInput = (input) => { | |||
| if (isInput(input) || (Array.isArray(input) && input.every(isInput))) { | |||
| return true | |||
| } else { | |||
| throw new Error(`Input not supported. Expected Buffer|ReadableStream|PullStream|File|Array<Object> got ${kindOf(input)}. Check the documentation for more info https://github.com/ipfs/interface-js-ipfs-core/blob/master/SPEC/FILES.md#add`) | |||
| throw new Error(`Input not supported. Expected Buffer|ReadableStream|PullStream|File|Array<Object>| got ${kindOf(input)}. Check the documentation for more info https://github.com/ipfs/interface-js-ipfs-core/blob/master/SPEC/FILES.md#add`) | |||
There was a problem hiding this comment.
Suggested change
| throw new Error(`Input not supported. Expected Buffer|ReadableStream|PullStream|File|Array<Object>| got ${kindOf(input)}. Check the documentation for more info https://github.com/ipfs/interface-js-ipfs-core/blob/master/SPEC/FILES.md#add`) | |
| throw new Error(`Input not supported. Expected Iterator|AsyncIterator|PullStream|File|Array<Object>| got ${kindOf(input)}. Check the documentation for more info https://github.com/ipfs/interface-js-ipfs-core/blob/master/SPEC/FILES.md#add`) |
|
Closing in favour of #6 which from a branch in this repo.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to accept async interators as arguments to
ipfs.addand friends.It also allows adding plain old js things like strings and arrays, so hooray for that.