fix: config handler should check if value is null (#1134)

ipfs · Dec 10, 2017 · 0444c42 · 0444c42
1 parent 5d61d93
commit 0444c42
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/src/http/api/resources/config.js b/src/http/api/resources/config.js
@@ -59,8 +59,9 @@ exports.getOrSet = {
     const value = request.pre.args.value
     const ipfs = request.server.app.ipfs
 
-    if (typeof value === 'object' &&
-        value.type === 'Buffer') {
+    // check that value exists - typeof null === 'object'
+    if (value && (typeof value === 'object' &&
+        value.type === 'Buffer')) {
       return reply({
         Message: 'Invalid value type',
         Code: 0

diff --git a/test/cli/config.js b/test/cli/config.js
@@ -45,6 +45,12 @@ describe('config', () => runOnAndOff((thing) => {
       })
     })
 
+    it('set a config key with null', () => {
+      return ipfs('config foo null --json').then((out) => {
+        expect(updatedConfig().foo).to.equal(null)
+      })
+    })
+
     it('set a config key with json', () => {
       return ipfs('config foo {"bar":0} --json').then((out) => {
         expect(updatedConfig().foo).to.deep.equal({ bar: 0 })